Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of snapetech-org/seerrng#628 (the Lumen part; the one server change,
server/lib/editionCompare, lives upstream only).Fixes from a full test pass on a live install after upgrading to 3.72.25 (SeerrNG + Lumen companion) and ChaptarrNG 0.9.986. Every control in Lumen was exercised at desktop and Firefox phone sizes against the real server (writes intercepted), plus a code-level bug hunt. Each fix has a browser or unit test that fails on current main.
Narrations (ChaptarrNG 0.9.986 has the data; it wasn't reaching Lumen)
compareBookEditionsonly looks editions up when it also has a title or identity (server/lib/editionCompare/index.tsterm && (title || identity || foreignBookId)), and Lumen sent onlyterm=work:N, so book pages had no narrations to choose from. Lumen now also sendsforeignBookId=hc:N.server/lib/editionCompare/index.ts): Chaptarr lookups qualify the work id (hc:427578) while the stored book keeps the bare form (427578), solocalBook.foreignBookId === match.foreignBookIdnever matched and the comparison fell back to the lookup (fewer editions, no owned flags). Now compared throughgetKnownBookIdentityAliases. New vitest case; server typecheck clean.Request lists showing available titles as missing
MAX_MEDIA_AVAILABILITY_CHECKS_PER_RESPONSE) and masks the rest. Lumen asked for 40–100 requests at a time, so on the live server 198 of 427 available titles showed as not available. Lumen now fetches request lists in pages of 15 and joins them.Other Lumen fixes
/settings/publicfailed after start; they now show the error with Retry.Tests
Lumen browser suite: 571 passed, 13 existing viewport skips.
server/lib/editionCompare: 19 passed; server typecheck clean; Prettier clean. Also verified on the live install after deploying: request lists show real availability (no masked titles in any page), book pages list narrations again (e.g. Wool: four English recordings, the owned one marked), and the narrator request sends the matching Chaptarr edition.Related, separate: #624 (sign-out error), #626 (Listen in Audiobookshelf), #627 (Requests rows before slow lookups), #625 (owned books missing from the library list).