Skip to content

Add Cakes, Trapdoors and Fence Gates (Compat), and misc fixes#614

Merged
BrentDaMage merged 13 commits into
nbcraft-org:masterfrom
fileshredder:master
Jun 2, 2026
Merged

Add Cakes, Trapdoors and Fence Gates (Compat), and misc fixes#614
BrentDaMage merged 13 commits into
nbcraft-org:masterfrom
fileshredder:master

Conversation

@fileshredder
Copy link
Copy Markdown
Contributor

Pretty much the title.

  • Adds Cakes and Trapdoors into the game and also adds fence gates for compat.
  • Also fixes some issues with fire and tilerenderer

Blocks Added:

  • Cakes
  • Trapdoors
  • Fence Gates

Changes:

  • Cake item has been turned into a TilePlanterItem to well, place cakes down
  • Fixed a wrong sign being used for the first person fire function in IteminHandRenderer which caused fire's planes to render in swapped positions in first person.
  • Fixed TileRenderer to read textures in correct direction vertically like it did in beta java, fixing textures like cake which had their side texture rendered incorrectly
  • Added defaultshape call in tilerenderer to fix state issues with metadata dependent blocks like trapdoors and cake, which would also change their state in the hotbar and inventory when lookin at their tile in the world
  • Fence tile and it's tesselation code was modified just to add one tiny function so they connect correctly with the fence gate

@fileshredder
Copy link
Copy Markdown
Contributor Author

Also made bookshelves and clay actually drop their items instead of returning nothing.

Comment thread projects/visual-studio/World/World.vcxproj Outdated
Comment thread projects/visual-studio/World/World.vcxproj.filters Outdated
Comment thread source/client/renderer/TileRenderer.cpp Outdated
Comment thread source/client/renderer/TileRenderer.cpp Outdated
Comment thread source/client/renderer/TileRenderer.cpp Outdated
Comment thread source/world/tile/Tile.cpp Outdated
Comment thread source/world/tile/Tile.cpp Outdated
Comment thread source/world/tile/TrapDoorTile.cpp Outdated
Comment thread source/world/tile/TrapDoorTile.cpp Outdated
Comment thread source/world/tile/TrapDoorTile.cpp Outdated
@BrentDaMage BrentDaMage added the enhancement New feature or request label May 28, 2026
@BrentDaMage BrentDaMage self-assigned this May 28, 2026
@fileshredder fileshredder requested a review from BrentDaMage May 28, 2026 11:32
@BrentDaMage
Copy link
Copy Markdown
Member

Can you mark the comments that you addressed as resolved please?

@BrentDaMage
Copy link
Copy Markdown
Member

The sides of the cake block are black when placed, and the cake tile (92) in the inventory renders like a flat carpet.

@fileshredder
Copy link
Copy Markdown
Contributor Author

The sides of the cake block are black when placed, and the cake tile (92) in the inventory renders like a flat carpet.
?

image

@fileshredder
Copy link
Copy Markdown
Contributor Author

The black side bug and the cake rendering like a carpet in the hotbar were both tilerenderer bugs that already should be fixed like seen in the screenshot?

@BrentDaMage BrentDaMage merged commit 70263e9 into nbcraft-org:master Jun 2, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants