Shouldn't mutate original data in res.end#51
Open
kanavarora wants to merge 1 commit into
Open
Conversation
Test cases for string and boolean responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In res.end we seem to be converting the incoming data to json to validate the request/response. However, the ideally the return from res.end should just be the original data. In all such cases, this MR just returns the original data, and removes the unnecessary conversion in stringify call in senddata.
Have added test cases for pure string and boolean responses too. (should add for number as well).
Note: boolean and number was already working. Was just failing for string. Issue Described here: #50