Skip to content

FEATURE: Replace GetArgs with GetOption enum#1092

Merged
jhpark816 merged 1 commit into
naver:developfrom
f1v3-dev:feat/v2-collection-get-option
May 20, 2026
Merged

FEATURE: Replace GetArgs with GetOption enum#1092
jhpark816 merged 1 commit into
naver:developfrom
f1v3-dev:feat/v2-collection-get-option

Conversation

@f1v3-dev
Copy link
Copy Markdown
Collaborator

@f1v3-dev f1v3-dev commented May 20, 2026

🔗 Related Issue

⌨️ What I did

테스트 코드 쪽에서 코드 포맷을 맞춰놓은 상태인 점 감안해주세요.

  • 컬렉션 조회 연산(lop, sop, mop)의 GetArgsGetOption enum으로 교체합니다.
    • 기존에 유효하지 않은 조합(withDelete=false, dropIfEmpty=true)을 허용하는 문제 방지
    • 세 가지 유효한 상태만을 표현하도록 제한 (NONE, DELETE, DROP)

@f1v3-dev f1v3-dev requested a review from oliviarla May 20, 2026 05:38
@f1v3-dev f1v3-dev self-assigned this May 20, 2026
@f1v3-dev f1v3-dev force-pushed the feat/v2-collection-get-option branch from bf620b1 to 0e7ca1e Compare May 20, 2026 06:01
@f1v3-dev
Copy link
Copy Markdown
Collaborator Author

f1v3-dev commented May 20, 2026

BopGetArgs 내부에서도 withDelete, dropIfEmpty를 사용하고 있기 때문에 해당 PR이 반영된 후에 BopGetAgs 분리 작업을 진행하도록 하겠습니다.

@jhpark816
Copy link
Copy Markdown
Collaborator

@oliviarla 리뷰 바랍니다.

@jhpark816 jhpark816 merged commit 6006604 into naver:develop May 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants