Skip to content

FIX: Forcefully use ScramSaslClientFactory instead of others#1083

Merged
jhpark816 merged 1 commit into
naver:masterfrom
uhm0311:develop
Apr 29, 2026
Merged

FIX: Forcefully use ScramSaslClientFactory instead of others#1083
jhpark816 merged 1 commit into
naver:masterfrom
uhm0311:develop

Conversation

@uhm0311
Copy link
Copy Markdown
Collaborator

@uhm0311 uhm0311 commented Apr 29, 2026

🔗 Related Issue

  • ScramSaslClient가 아닌 다른 SaslClient 구현체가 사용될 경우, 인증 과정이 정상적으로 동작하지 않을 수 있다.

⌨️ What I did

  • 항상 ScramSaslClientFactory를 사용하여, ScramSaslClient를 반드시 사용하도록 합니다.

@uhm0311 uhm0311 requested a review from jhpark816 April 29, 2026 09:27
@jhpark816 jhpark816 requested a review from oliviarla April 29, 2026 09:30
@jhpark816
Copy link
Copy Markdown
Collaborator

@oliviarla 리뷰 바랍니다.

oliviarla
oliviarla previously approved these changes Apr 29, 2026

final SaslClient sc;
try {
sc = Sasl.createSaslClient(authDescriptor.getMechs(), null,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uhm0311

import javax.security.sasl.Sasl;

기존에 위와 같이 import하면, 장비 환경의 java security 설정에 따라 static Sasl 객체가 달라졌다는 것이죠?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 코드의 버그인 거네요.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sasl 객체의 createSaslClient() 메소드에서 반환해주는 값이 달라질 수 있습니다.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static Sasl 객체는 동일하고 java security 설정에 따라 createSaslClient() 메소드에서 반환해주는 객체가 달라지는 건가요?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇습니다.

@jhpark816
Copy link
Copy Markdown
Collaborator

@uhm0311
CI 문제는 일시적인 거죠?

@uhm0311
Copy link
Copy Markdown
Collaborator Author

uhm0311 commented Apr 29, 2026

CI 문제는 일시적인 거죠?

연산에서 타임아웃이 발생한 것이므로 일시적인 문제입니다.

@uhm0311 uhm0311 changed the base branch from develop to master April 29, 2026 10:31
@uhm0311 uhm0311 dismissed oliviarla’s stale review April 29, 2026 10:31

The base branch was changed.

@jhpark816 jhpark816 merged commit a9c94f9 into naver:master Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants