Skip to content

FIX: Add missing input validation#1081

Merged
jhpark816 merged 1 commit into
naver:developfrom
f1v3-dev:refactor/v2-validate
Apr 29, 2026
Merged

FIX: Add missing input validation#1081
jhpark816 merged 1 commit into
naver:developfrom
f1v3-dev:refactor/v2-validate

Conversation

@f1v3-dev
Copy link
Copy Markdown
Collaborator

🔗 Related Issue

⌨️ What I did

Operation 요청 파라미터에 대한 검증을 추가합니다.

  • multiGet, multiGets: validateKey() + checkDupKey()
  • multiDelete: checkDupKey() (addOp(key, op) 를 통해 내부에서 validateKey() 검증 진행)
  • bop 단일 BKey 파라미터: validateBKey(BKey) 추가
  • bop 범위 BKey 파라미터: verifyBKeyRange() 메서드에서 verifyBKey(from | to) 검증 추가
  • mop MKey 파라미터: validateMKey() 추가

@f1v3-dev f1v3-dev requested a review from oliviarla April 28, 2026 03:09
@f1v3-dev f1v3-dev self-assigned this Apr 28, 2026
return future;
}

private static void validateBKey(BKey bKey) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BKey 타입 생성 시에 validateBKey와 동일한 이뤄지기 때문에 이 메서드는 필요 없어보입니다.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

말씀해주신대로 BKey 객체에 대한 검증은 생성자에서 진행하기 때문에 제거하였습니다.

@f1v3-dev f1v3-dev force-pushed the refactor/v2-validate branch from c330261 to 02f9e36 Compare April 29, 2026 03:18
@f1v3-dev f1v3-dev requested a review from oliviarla April 29, 2026 03:20
@oliviarla oliviarla requested a review from jhpark816 April 29, 2026 05:12
@jhpark816
Copy link
Copy Markdown
Collaborator

@f1v3-dev
CI 확인 바랍니다.

@f1v3-dev
Copy link
Copy Markdown
Collaborator Author

@f1v3-dev CI 확인 바랍니다.

확인 완료했습니다.

@jhpark816 jhpark816 merged commit a5b54ac into naver:develop Apr 29, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants