feat: SMC writer gating, F*Md-less fans, helper install & dev helper build#58
Merged
feat: SMC writer gating, F*Md-less fans, helper install & dev helper build#58
Conversation
- Only attempt direct SmcWriter when running as root; otherwise prefer helper socket. - When F*Md is absent (some Apple Silicon), skip forced-mode handoff and write F*Tg directly; restore auto is a no-op. - Refactor helper install shell script: launchctl enable/kickstart, safer bootout. - Add dev:prepare-helper and run it before Vite in Tauri dev so the helper binary exists. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SmcWriterwhen the process effective UID is root; otherwise skip direct I/O and fall through to the privileged helper socket path.F*Tgdirectly;set_fan_autobecomes a no-op for those fans. Adds unit tests and an ignored hardware smoke test.build_helper_install_shell_commands; fix LaunchDaemon flow (launchctl enable,kickstart, saferbootout).pnpm dev:prepare-helperbuildsfanguard-helper;beforeDevCommandruns it before Vite so the helper exists duringtauri dev.Verification
cd src-tauri && cargo test— all tests passed (2 ignored hardware-dependent).Notes
originwas switched from HTTPS togit@github.com:naufaldi/mac-fan-ctrl.gitfor push (HTTPS auth was unavailable in this environment). Switch back if you prefer HTTPS.Made with Cursor