feat: Allowed full passthrough of orchestrator settings - #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88
This pull request refactors and improves the main public API in
src/index.tsfor clarity, maintainability, and better type safety. The changes focus on updating type definitions, simplifying option handling, and cleaning up code style for consistency.Type and Options Refactoring:
InitFederationOptionsinterface with new types:NgOrchestratorOptionsandNgNFOptions, aligning the API more closely with orchestrator options and improving type safety.initFederationfunction to destructure and forward options more cleanly, and to use the new types. This makes it easier to pass advanced options and improves clarity around which options are supported.Code Style and Consistency:
Function Improvements:
loadRemoteModuleand related helper functions for better readability, argument normalization, and error handling. [1] [2] [3]Overall, these changes modernize the API, improve type safety, and make the codebase more maintainable.