Skip to content

feat: Allowed full passthrough of orchestrator settings - #92

Merged
Aukevanoost merged 1 commit into
mainfrom
issues/88
Jul 17, 2026
Merged

feat: Allowed full passthrough of orchestrator settings#92
Aukevanoost merged 1 commit into
mainfrom
issues/88

Conversation

@Aukevanoost

@Aukevanoost Aukevanoost commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Closes #88

This pull request refactors and improves the main public API in src/index.ts for clarity, maintainability, and better type safety. The changes focus on updating type definitions, simplifying option handling, and cleaning up code style for consistency.

Type and Options Refactoring:

  • Replaces the old InitFederationOptions interface with new types: NgOrchestratorOptions and NgNFOptions, aligning the API more closely with orchestrator options and improving type safety.
  • Refactors the initFederation function to destructure and forward options more cleanly, and to use the new types. This makes it easier to pass advanced options and improves clarity around which options are supported.

Code Style and Consistency:

  • Standardizes all import/export statements to use double quotes for consistency.
  • Updates all string literals to use double quotes and ensures function signatures and error messages are consistently formatted. [1] [2] [3]

Function Improvements:

  • Refactors the loadRemoteModule and related helper functions for better readability, argument normalization, and error handling. [1] [2] [3]

Overall, these changes modernize the API, improve type safety, and make the codebase more maintainable.

@Aukevanoost
Aukevanoost merged commit c0d07d7 into main Jul 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make strictVersion fail fast on incompatible shared dependencies

1 participant