fix: Declared mrmime as a runtime dependency (20.3.x) - #105
Open
Ionaru wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100 for the 20.x line (same fix as #104)
packages/angular/src/builders/build/builder.tsandpackages/angular/src/plugin/index.tsimportmrmimeat runtime, but the hand-curateddependencieslist inpackages/angular/package.jsonnever included it (only the workspace root manifest did, which is why local development never noticed). The import only resolved while another installed package happened to hoistmrmime(typically the v3 mainline package left in place during migration), andng buildfails withCannot find package 'mrmime'once that is uninstalled.This adds
mrmimeto the publishable manifest'sdependencies, matching the mainline package. Verified locally:nx build angular-adapternow emitspackages/angular/dist/package.jsonwithmrmimeunderdependencies, and the test target passes.Note on scope:
esbuildandjson5are also imported at runtime without being declared (as are@schematics/angularand@nx/devkitin the schematics and generator entry points). Those are deliberately not added here because they are highly likely to be already installed through Angular's own dependencies (@angular/build,@angular-devkit/*), unlikemrmime, which nothing else in an Angular workspace provides.