Skip to content

Fix #197, Initialize Variable msg_size in ci_lab_passthru_decode.c#198

Merged
arielswalker merged 1 commit into
nasa:devfrom
arielswalker:fix-197-initialize-variable-msgsize
Jun 23, 2026
Merged

Fix #197, Initialize Variable msg_size in ci_lab_passthru_decode.c#198
arielswalker merged 1 commit into
nasa:devfrom
arielswalker:fix-197-initialize-variable-msgsize

Conversation

@arielswalker

@arielswalker arielswalker commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Describe the contribution
Fixes #197

Testing performed
Workflows and reran CodeSonar. CodeSonar analysis link provided in the internal GitHub issue.

Expected behavior changes
Resolve CodeSonar warning of Uninitialized Variable in ci_lab_passthru_decode.c

System(s) tested on
GitHub Actions and CodeSonar

Additional context
Adds Missing Parentheses warning for

if (Status != CFE_SUCCESS || MsgSize > SourceSize)

This can be suppressed on CodeSonar or updated. This style can be found in other apps.

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Walker, MCSG TECH.

@arielswalker arielswalker self-assigned this Jun 16, 2026
@arielswalker arielswalker force-pushed the fix-197-initialize-variable-msgsize branch from 617d3b1 to 2314b4f Compare June 16, 2026 19:25
Comment thread fsw/src/ci_lab_passthru_decode.c Outdated
@arielswalker arielswalker force-pushed the fix-197-initialize-variable-msgsize branch from 2314b4f to c16d2f3 Compare June 23, 2026 14:04
@arielswalker arielswalker requested a review from jphickey June 23, 2026 14:22
@arielswalker arielswalker merged commit fdd6804 into nasa:dev Jun 23, 2026
11 checks passed
@arielswalker arielswalker deleted the fix-197-initialize-variable-msgsize branch June 23, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uninitialized Variables in ci_lab_passthru_decode.c

3 participants