Skip to content

Fix #146, Add Null Terminator for FileName in FM_GetDirListFileCmd#147

Merged
arielswalker merged 1 commit into
nasa:devfrom
arielswalker:fix-146-add-null-terminator-filename-getdirlistfilecmd
Jul 16, 2026
Merged

Fix #146, Add Null Terminator for FileName in FM_GetDirListFileCmd#147
arielswalker merged 1 commit into
nasa:devfrom
arielswalker:fix-146-add-null-terminator-filename-getdirlistfilecmd

Conversation

@arielswalker

Copy link
Copy Markdown
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fixes #146

Testing performed
Reran the internal static code analysis to ensure warning was resolved. Used the following commands to build:

git clone https://github.com/nasa/cFS.git
cd cFS
git submodule init
git submodule update
cp -f ./cfe/cmake/Makefile.sample Makefile
rm -rf sample_defs && cp -r ./cfe/cmake/sample_defs sample_defs

Update sample_defs/targets.cmake

LIST(APPEND MISSION_GLOBAL_APPLIST fm)

Run make prep and install

make SIMULATION=native OMIT_DEPRECATED=false BUILDTYPE=debug ENABLE_UNIT_TESTS=false CMAKE_EXPORT_COMPILE_COMMANDS=ON MISSIONCONFIG=sample prep
make install

Expected behavior changes
Resolves static code analysis warning of non-null-terminated-string

System(s) tested on
Internal static code analysis tool, RedHat, cFS dev

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Walker, MCSG TECH.

@arielswalker arielswalker self-assigned this Jul 15, 2026
@Cameron-Sykes Cameron-Sykes self-requested a review July 16, 2026 14:16
@arielswalker arielswalker merged commit 4698971 into nasa:dev Jul 16, 2026
20 checks passed
@arielswalker arielswalker deleted the fix-146-add-null-terminator-filename-getdirlistfilecmd branch July 16, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non-null-terminated-string in FM_GetDirListFileCmd

3 participants