Skip to content

v3: four composite actions (setup, verify, version-proof, health) - #253

Merged
narduk-lane-automation[bot] merged 4 commits into
mainfrom
v3/actions
Nov 18, 2026
Merged

narduk-lane-automation[bot] merged 4 commits into
mainfrom
v3/actions

Conversation

@narduk-lane-automation

@narduk-lane-automation narduk-lane-automation Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Do not merge yet (Narduk, 11-17): opened for review only. PACC·TRAC's own stack lands first; then this, then the v3.0.0 / v3 tags by hand.

What this is

v3 of the estate's shared CI is four composite actions under actions/, not more reusable workflows (Logan's call 5 on the PACC CI page, 11-17; Narduk agreed the shape):

Action What it does
actions/setup Node from .node-version, pnpm from packageManager, the pnpm store where the runner can keep it, pnpm install --frozen-lockfile
actions/verify Runs the checks Config/remote-gate.json names: what the diff selects on a pull request, the whole list otherwise, side by side, one timed line each
actions/version-proof Polls a URL until it answers this commit's SHA; red when it never does
actions/health Polls a health URL until it answers 200; red, with the body, when it never does

Why composite actions

A callable here must end in a Required job (lint rule R5), carries a 500-character runs-on, and usually an admission job. That is the extra-seat shape PACC·TRAC removed on 11-17, when its pull requests went from six jobs to one. A composite action is steps inside the caller's own job: the caller keeps runs-on, if, needs, permissions and the check's name, and there is nothing here to route.

v1 and v2 (everything in .github/workflows/) are untouched and keep their callers. No tag moves in this pull request.

What changed

  • actions/setup/action.yml, actions/verify/action.yml + verify.py, actions/version-proof/action.yml, actions/health/action.yml, actions/README.md (a caller, the gate file, what is not here yet).
  • scripts/test_actions.py and one step in ci.yml that runs it: actionlint and lint_callables.py read only .github/workflows, so this is the one check that sees actions/.
  • A paragraph each in README.md and AGENTS.md.

10 files.

Review, first pass: 3 findings, all fixed (cc7f751)

  • verify read git's changed-file list line by line; a name git quotes (non-ASCII, a tab, a quote) matched no rule and its checks were not chosen. Now NUL-separated.
  • version-proof accepted the commit in the body of a 503 or at the head of a response cut short. Now only a whole 200.
  • setup used GNU df --output=target, which stops a macOS runner. Now POSIX df -P.

Each has a test that fails on the code before the fix. PACC·TRAC's own verify.py and /version polls carry the first two (no tracked file there has such a name today); they get the same fix when PACC·TRAC becomes a caller.

Where each piece has run

Piece Proof
setup PACC·TRAC's copy (.github/actions/setup, the same steps without the two inputs) ran green in a bare dispatch of its whole new CI (run 44189708414: verify, both build legs, page-world, five page-gate shards, including after a sparse blobless checkout) and in three real pull request runs (pacc-trac #1896, #1897, #1898), 17 to 52 s
verify.py The same script as PACC·TRAC's .github/scripts/verify.py with the repository's names taken out (gate file, alone and base from the environment); PACC·TRAC's has run in every one of its one-job pull request runs since #1891. The diff between the two is comments, five constants, a default for a gate file with no always list, and one guard for an unknown alone name
version-proof, health The loops PACC·TRAC's deploys paste 6 and 15 times, lifted. Proven here by test_actions.py against a local HTTP server only. No deploy has run them
All four python3 scripts/test_actions.py: 71 checks pass. It runs each step's shipped script (a shimmed df and the machine's own, a local HTTP server) and shellcheck over it

Not proven: no repository calls these from this repository yet. PACC·TRAC becomes the first caller, pinned to the v3 SHA, after this merges and is tagged.

Checks (local)

Check Result
python3 scripts/test_actions.py 71 checks pass
python3 scripts/lint_callables.py exit 0
actionlint not run: not installed on this machine. This repository's CI runs it

narpihar added 3 commits November 17, 2026 16:06
A caller keeps its own jobs and uses these as steps, so there is no runner input, no Required job and nothing here to
route. From PACC·TRAC's CI after it went from six jobs per pull request to one (2026-11-17):

- actions/setup: Node from .node-version, pnpm, the store where the runner can keep it, a frozen install.
- actions/verify: runs the checks Config/remote-gate.json names (the file remote-gate --changed reads): what the diff
  selects on a pull request, the whole list otherwise, side by side, one timed line each.
- actions/version-proof: polls a URL until it answers this commit's SHA.
- actions/health: polls a health URL until it answers 200.

scripts/test_actions.py runs each step's shipped script (67 checks, with shellcheck) and is a step of ci.yml.
v1 and v2 are untouched. Not run in CI; no tag moved; no caller yet.
On the estate's runners /sys/fs/cgroup/memory.peak is the shared host's figure,
not the job's: PACC's first run printed 196 GiB for verify on x740 and 20.0 GiB
for a build on hetzner (the hosts' sizes). A number that measures nothing is
not printed.
The example asked for fetch-depth 0, which is the slow shape: verify compares a pull request with HEAD^1 only.
A repository whose own checks read history adds filter: blob:none (PACC·TRAC, 2026-11-17: 28 s at the median and
up to 653 s with every blob; 4 to 10 s without).
@narduk-lane-automation

Copy link
Copy Markdown
Contributor Author

Review gate (gpt-6.1-sol, high, on openai-codex, the rungs above could not (fable: the builder's family); built by anthropic/claude-fable-5-2 (--builder)) of 67e7b31. Fix: 3 blocking finding(s). Fix them and run tools/review run 253 -R narduk-enterprises/workflows again (it reads only the fix), or mark each with tools/review classify.

Gated:

Verify can silently skip required checks for valid filenames. The probes also have a fail-open case, and setup assumes GNU utilities without documenting a Linux-only restriction.

  • F1 bug actions/verify/verify.py:59: Parsing newline-delimited git diff output without disabling Git path quoting silently drops checks for quoted filenames. Git normally quotes filenames containing non-ASCII characters, tabs, or newlines, so src/café.ts can arrive as a quoted, escaped string rather than its actual path. Rules such as src/** then miss it, and the existence check also fails; use NUL-delimited output and parsing.
  • F2 risk actions/version-proof/action.yml:34: Version proof ignores curl failures and HTTP status, allowing a failed response to count as successful deployment proof. A server can return the expected SHA with a 503, or send it before a truncated or timed-out transfer. Both cases currently pass because only captured text is checked.
  • F3 risk actions/setup/action.yml:30: Setup unconditionally requires GNU df, so it fails on macOS runners before reaching its fallback. macOS df rejects --output=target, and pipefail terminates the step. The shimmed df tests hide this portability failure despite the action leaving runner selection to callers.

… first

Review of #253 (gpt-6.1-sol), all three real:

- verify read `git diff --name-only` line by line. git quotes and escapes a name with a non-ASCII character, a
  tab or a quote in it, no rule matches the quoted text, and that file's checks were silently not chosen.
  Now `-z`, split on NUL.
- version-proof compared the body alone, so the commit in the body of a 503, or at the head of a response cut
  short, counted as proof. Now only a whole answer with a 200 does; the error names the status.
- setup used GNU `df --output=target`, which stops a macOS runner before the fallback. Now POSIX `df -P`.

test_actions.py: 71 checks. The four new ones (a quoted name, a 503 with the commit, a cut response, this
machine's own df) fail on the code before this commit and pass on it.
@narduk-lane-automation

Copy link
Copy Markdown
Contributor Author

Review gate (gpt-6.1-sol, high, on openai-codex, the rungs above could not (fable: the builder's family); built by anthropic/claude-fable-5-2 (--builder)) of cc7f751 since 67e7b31. Pass: nothing blocking.

Gated:

The fixes address all three earlier findings. No new blocking issues were found in this diff.

Resolved since 67e7b31: F1, F2, F3. Still open: none.

@narduk-lane-automation
narduk-lane-automation Bot merged commit 3621fe9 into main Nov 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants