Repository navigation
v3: four composite actions (setup, verify, version-proof, health) - #253
Conversation
A caller keeps its own jobs and uses these as steps, so there is no runner input, no Required job and nothing here to route. From PACC·TRAC's CI after it went from six jobs per pull request to one (2026-11-17): - actions/setup: Node from .node-version, pnpm, the store where the runner can keep it, a frozen install. - actions/verify: runs the checks Config/remote-gate.json names (the file remote-gate --changed reads): what the diff selects on a pull request, the whole list otherwise, side by side, one timed line each. - actions/version-proof: polls a URL until it answers this commit's SHA. - actions/health: polls a health URL until it answers 200. scripts/test_actions.py runs each step's shipped script (67 checks, with shellcheck) and is a step of ci.yml. v1 and v2 are untouched. Not run in CI; no tag moved; no caller yet.
On the estate's runners /sys/fs/cgroup/memory.peak is the shared host's figure, not the job's: PACC's first run printed 196 GiB for verify on x740 and 20.0 GiB for a build on hetzner (the hosts' sizes). A number that measures nothing is not printed.
The example asked for fetch-depth 0, which is the slow shape: verify compares a pull request with HEAD^1 only. A repository whose own checks read history adds filter: blob:none (PACC·TRAC, 2026-11-17: 28 s at the median and up to 653 s with every blob; 4 to 10 s without).
|
Review gate (gpt-6.1-sol, high, on openai-codex, the rungs above could not (fable: the builder's family); built by anthropic/claude-fable-5-2 (--builder)) of Gated: Verify can silently skip required checks for valid filenames. The probes also have a fail-open case, and setup assumes GNU utilities without documenting a Linux-only restriction.
|
… first Review of #253 (gpt-6.1-sol), all three real: - verify read `git diff --name-only` line by line. git quotes and escapes a name with a non-ASCII character, a tab or a quote in it, no rule matches the quoted text, and that file's checks were silently not chosen. Now `-z`, split on NUL. - version-proof compared the body alone, so the commit in the body of a 503, or at the head of a response cut short, counted as proof. Now only a whole answer with a 200 does; the error names the status. - setup used GNU `df --output=target`, which stops a macOS runner before the fallback. Now POSIX `df -P`. test_actions.py: 71 checks. The four new ones (a quoted name, a 503 with the commit, a cut response, this machine's own df) fail on the code before this commit and pass on it.
|
Review gate (gpt-6.1-sol, high, on openai-codex, the rungs above could not (fable: the builder's family); built by anthropic/claude-fable-5-2 (--builder)) of Gated: The fixes address all three earlier findings. No new blocking issues were found in this diff. Resolved since 67e7b31: F1, F2, F3. Still open: none. |
Do not merge yet (Narduk, 11-17): opened for review only. PACC·TRAC's own stack lands first; then this, then the
v3.0.0/v3tags by hand.What this is
v3 of the estate's shared CI is four composite actions under
actions/, not more reusable workflows (Logan's call 5 on the PACC CI page, 11-17; Narduk agreed the shape):actions/setup.node-version, pnpm frompackageManager, the pnpm store where the runner can keep it,pnpm install --frozen-lockfileactions/verifyConfig/remote-gate.jsonnames: what the diff selects on a pull request, the whole list otherwise, side by side, one timed line eachactions/version-proofactions/healthWhy composite actions
A callable here must end in a
Requiredjob (lint rule R5), carries a 500-characterruns-on, and usually an admission job. That is the extra-seat shape PACC·TRAC removed on 11-17, when its pull requests went from six jobs to one. A composite action is steps inside the caller's own job: the caller keepsruns-on,if,needs,permissionsand the check's name, and there is nothing here to route.v1 and v2 (everything in
.github/workflows/) are untouched and keep their callers. No tag moves in this pull request.What changed
actions/setup/action.yml,actions/verify/action.yml+verify.py,actions/version-proof/action.yml,actions/health/action.yml,actions/README.md(a caller, the gate file, what is not here yet).scripts/test_actions.pyand one step inci.ymlthat runs it: actionlint andlint_callables.pyread only.github/workflows, so this is the one check that seesactions/.README.mdandAGENTS.md.10 files.
Review, first pass: 3 findings, all fixed (cc7f751)
verifyread git's changed-file list line by line; a name git quotes (non-ASCII, a tab, a quote) matched no rule and its checks were not chosen. Now NUL-separated.version-proofaccepted the commit in the body of a 503 or at the head of a response cut short. Now only a whole 200.setupused GNUdf --output=target, which stops a macOS runner. Now POSIXdf -P.Each has a test that fails on the code before the fix. PACC·TRAC's own
verify.pyand/versionpolls carry the first two (no tracked file there has such a name today); they get the same fix when PACC·TRAC becomes a caller.Where each piece has run
setup.github/actions/setup, the same steps without the two inputs) ran green in a bare dispatch of its whole new CI (run 44189708414:verify, bothbuildlegs,page-world, fivepage-gateshards, including after a sparse blobless checkout) and in three real pull request runs (pacc-trac #1896, #1897, #1898), 17 to 52 sverify.py.github/scripts/verify.pywith the repository's names taken out (gate file,aloneand base from the environment); PACC·TRAC's has run in every one of its one-job pull request runs since #1891. The diff between the two is comments, five constants, a default for a gate file with noalwayslist, and one guard for an unknownalonenameversion-proof,healthtest_actions.pyagainst a local HTTP server only. No deploy has run thempython3 scripts/test_actions.py: 71 checks pass. It runs each step's shipped script (a shimmeddfand the machine's own, a local HTTP server) and shellcheck over itNot proven: no repository calls these from this repository yet. PACC·TRAC becomes the first caller, pinned to the
v3SHA, after this merges and is tagged.Checks (local)
python3 scripts/test_actions.pypython3 scripts/lint_callables.py