You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cursor-review: de-escalating labels (no-ai-review, review-p2) have no actor check #126
narduk-enterprises/agent-infrastructure → docs/agents/review-routing.md states that labels may only escalate, and only when an allowlisted actor applied them. Neither condition is enforced: the script never receives github.event.sender, so any author — including an estate agent opening its own pull request — can skip the reviewer that company-hq D-AGENT-REVIEW-2 makes the merge gate for that merge.
Evidence
Raised by the Cursor reviewer on #125 (head 127980ff), thread #125 (comment). It reproduced the review-p2 leg offline: default src/a.ts files plus PR_LABELS=["review-p2"] skips with no POST /v1/agents.
The same PR deliberately removed the title-based P2 signal for exactly this reason — a chore: prefix was an author-controlled skip of a merge-gating reviewer — which is why the label version is worth deciding rather than leaving implicit.
Dropping review-p2 alone would move the capability one label to the left rather than remove it: no-ai-review predates it and grants the same skip with no actor check either. And P2-as-an-assertable-class is the rule Logan picked over a numeric cap on 2026-09-19 ("No numeric cap, only the P0/P1/P2 class rule"), so narrowing it is a decision for him, not a quiet reviewer-loop edit.
Proposed change
Plumb github.event.sender.login (and, for labeled, the label actor) into the script as PR_EVENT_ACTOR.
Decide the policy explicitly, as a needs-decision question: which actors may apply a de-escalating label, and whether a de-escalation applied by the pull request's own author should be refused outright, honoured with a loud ::notice::, or recorded in the launch ledger for later audit.
Enforce whichever answer lands, for no-ai-review and review-p2 together — they are one policy, not two.
Done when
The script refuses (or records) a de-escalating label from an actor the policy does not allow, with a test per branch, and docs/agents/review-routing.md's "labels may only escalate" sentence is either true or amended to describe what actually ships.
Obsolete: #166 (merged 2026-09-28) deleted cursor-review.yml and its scripts, and the runners PR review bot (runners#212) replaced it. If the label actor check still matters for the bot, it belongs in narduk-enterprises/runners.
Activity
loganrenz commentedon Oct 8, 2026
Obsolete: #166 (merged 2026-09-28) deleted cursor-review.yml and its scripts, and the runners PR review bot (runners#212) replaced it. If the label actor check still matters for the bot, it belongs in narduk-enterprises/runners.