Fix automatic RCS consent request semantics - #3
Merged
naormeit merged 2 commits intoSep 11, 2026
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a narrow correctness follow-up stacked on
rcs-bounty-2994, the branch currently used by microG PR microg#3784.The automatic RCS consent path was reusing the parsed requested
ConsentVersioninside the nestedRcsConsentrecord and constructing the request header without the consent API trigger. This follow-up aligns those request semantics by:RcsConsent.consent_versiontoRCS_CONSENT;SetConsentRequest.consent_version;CONSENT_API_TRIGGER;Commits:
516c1eb5af060c4330c9b6a25318f20c58fddd0c— production fixd8dfdffa88e72269a5a73a657c3bf711af8143cf— regression testsVerification:
assembleDebugpasses on the production and test commits in the fork CI.keeltrace/GmsCore#34537649271passes the focused JUnit classRcsAutoConsentRequestSemanticsTest.:play-services-constellation-core:lintDebugpasses in that proof run.assembleReleasepasses in that proof run.lintDebugstill reportsMissingPermissioninplay-services-droidguard/core/src/main/kotlin/org/microg/gms/droidguard/core/NetworkHandleProxyFactory.kt:99; the identical finding is present both before and after the regression-test commit, so it is unrelated to this two-commit Constellation delta.No physical-device/SIM RCS end-to-end test was performed for this follow-up, and this PR does not claim to independently solve or own the full microg#2994 bounty. It is intended to be reviewed/cherry-picked into the active integration work in microG PR microg#3784.