Skip to content

Fix automatic RCS consent request semantics - #3

Merged
naormeit merged 2 commits into
naormeit:rcs-bounty-2994from
keeltrace:keeltrace/2994-rcs-auto-consent-semantics
Sep 11, 2026
Merged

Fix automatic RCS consent request semantics#3
naormeit merged 2 commits into
naormeit:rcs-bounty-2994from
keeltrace:keeltrace/2994-rcs-auto-consent-semantics

Conversation

@keeltrace

Copy link
Copy Markdown

This is a narrow correctness follow-up stacked on rcs-bounty-2994, the branch currently used by microG PR microg#3784.

The automatic RCS consent path was reusing the parsed requested ConsentVersion inside the nested RcsConsent record and constructing the request header without the consent API trigger. This follow-up aligns those request semantics by:

  • forcing RcsConsent.consent_version to RCS_CONSENT;
  • preserving the caller/request-specific consent version in SetConsentRequest.consent_version;
  • setting the request trigger to CONSENT_API_TRIGGER;
  • adding focused regression tests for both invariants.

Commits:

  • 516c1eb5af060c4330c9b6a25318f20c58fddd0c — production fix
  • d8dfdffa88e72269a5a73a657c3bf711af8143cf — regression tests

Verification:

  • assembleDebug passes on the production and test commits in the fork CI.
  • Isolated proof CI run keeltrace/GmsCore#34537649271 passes the focused JUnit class RcsAutoConsentRequestSemanticsTest.
  • :play-services-constellation-core:lintDebug passes in that proof run.
  • Independent full assembleRelease passes in that proof run.
  • Repository-wide lintDebug still reports MissingPermission in play-services-droidguard/core/src/main/kotlin/org/microg/gms/droidguard/core/NetworkHandleProxyFactory.kt:99; the identical finding is present both before and after the regression-test commit, so it is unrelated to this two-commit Constellation delta.

No physical-device/SIM RCS end-to-end test was performed for this follow-up, and this PR does not claim to independently solve or own the full microg#2994 bounty. It is intended to be reviewed/cherry-picked into the active integration work in microG PR microg#3784.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants