Fix Asterism RCS consent fallback without Gaia entry - #1
Open
keeltrace wants to merge 1 commit into
Open
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Asterism
getConsentimplementation only reads matchinggaia_consents.For RCS requests without a matching Gaia/account consent entry, this causes the API to return
NO_CONSENTeven when the server response contains an RCS-specific consent value. The SetConsent implementation already sends RCS consent through the dedicatedrcs_consentfield.Change
Preserve matching Gaia consent behavior, but when the caller is the RCS Asterism client and there is no matching Gaia entry, fall back to the server's RCS-specific consent. Non-RCS clients are unchanged.
Focused unit coverage verifies:
NO_CONSENTWhy this matters
Consent is part of the RCS phone-number-verification acceptance path. Testing documented in microg#2994 showed that establishing RCS consent changed the server response from
FAILED_PRECONDITIONto a normal verification flow.This change only corrects the Asterism read-side mapping. It does not claim to solve the remaining DroidGuard/Tachyon, carrier, or end-to-end RCS issues.
Prior work
This is a focused follow-up to the Constellation/Asterism implementation by @opstic in microg#3359 / microg#3360 and the integrated work in microg#3784.
Verification
Prepared and tested against
naormeit/GmsCore:rcs-bounty-2994at063ccbea736763234b439f4a5802ccbe18e27649../gradlew :play-services-asterism-core:testDebugUnitTestwithANDROID_HOME=/home/j/Android/Sdk: PASS — 5 tests, 0 failures, 0 errors./gradlew :play-services-asterism-core:lintDebugwith the same SDK: PASS — no issues found./gradlew :play-services-asterism-core:assembleDebugwith the same SDK: PASS — BUILD SUCCESSFULgit diff --check: PASSLimitations
No locked-bootloader device/SIM end-to-end RCS verification was performed. No claim is made that this patch alone completes RCS provisioning.