fix: roost panics on musl (noq-udp SCM_TIMESTAMPNS) - #16
Merged
Conversation
The test treated "Connection closed" in ssh's output as reaching the authentication stage. That string is exactly what ssh prints when the `fly` proxy command dies, so a panic in roost or fly produced a green run. A second fallback counted ssh's exit code 255 as success, which is ssh's generic connection-failure code. Both masked a real crash: every musl job since 0.2.0 aborted with `assertion failed: align_of::<T>() <= align_of::<C>()` in noq-udp and still reported SUCCESS. Require the run to reach publickey/password rejection, which only happens once the tunnel has carried the SSH handshake end to end, and fail outright on a panic in either process or on a roost that is no longer alive after the connection attempt. Windows had the same two holes and gets the same treatment.
noq-udp 1.1.0 enables SO_TIMESTAMPNS unconditionally on Linux, so the kernel attaches an SCM_TIMESTAMPNS control message to every packet we receive. Decoding it asserts align_of::<timespec>() <= align_of::<cmsghdr>(). musl's cmsghdr is socklen_t + padding + two c_int, so it aligns to 4 while timespec aligns to 8, and the first inbound packet aborts the process. glibc's cmsg_len is a size_t, so the assert holds there. Our Linux release artifacts are musl on both arches, which is why this reproduced everywhere in #15 and never on macOS or Windows. noq-udp 1.1.1 disables the socket option (n0-computer/noq#774) and changes nothing else.
dignifiedquire
force-pushed
the
fix/roost-panic-musl
branch
from
August 3, 2026 10:07
e892037 to
654e233
Compare
dignifiedquire
marked this pull request as ready for review
August 3, 2026 10:16
matheus23
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15.