Skip to content

fix: check that frozen.build exists before trying to access it#497

Open
conorh wants to merge 1 commit into
mzgoddard:masterfrom
conorh:master
Open

fix: check that frozen.build exists before trying to access it#497
conorh wants to merge 1 commit into
mzgoddard:masterfrom
conorh:master

Conversation

@conorh

@conorh conorh commented Apr 10, 2019

Copy link
Copy Markdown

If there is a compilation where frozen.build is not generated for some reason then the check here would fail and throw an exception:

   Could not freeze FILE_NAME: Cannot read property 'hash' of undefined

Added check to see if the build exists, and then fall through to regenerate if it does not.

@conorh conorh changed the title Check that frozen.build exists before trying to access it fix: check that frozen.build exists before trying to access it May 29, 2019
If there is a compilation where frozen.build is not generated for some reason,
then the check here would fail and throw an exception:

   Could not freeze FILE_NAME: Cannot read property 'hash' of undefined

We check to see if the build exists and then fall through to regenerate if
it does not.
@larixer

larixer commented Jun 28, 2019

Copy link
Copy Markdown

@mzgoddard Can we have this merged?

@larixer

larixer commented Sep 20, 2019

Copy link
Copy Markdown

@mzgoddard Could you please, please review this PR and merge it? This problem is really a showstopper for us.

@eddieferrer

Copy link
Copy Markdown

Any update on merging this in?

@bovas85

bovas85 commented May 3, 2020

Copy link
Copy Markdown

bump

@elevatebart

Copy link
Copy Markdown

Can anyone look at the travis tests, see why they are not passing?

@ansballard

Copy link
Copy Markdown

So the tests aren't passing because npm run lint returns errors (calls prettier --list-different ...). Running npm run lint:fix should get travis to pass, as confirmed on a branch I made from this one. I actually went back a year or so in the travis build history and not a single run has succeeded, so we could merge this as is, especially since it's been tested via use of hard-source-webpack-plugin-fixed-hashbug.

TL;DR this looks perfectly safe to merge, with or without fixing the liner errors that are already in master anyway.

@dazjean

dazjean commented May 14, 2021

Copy link
Copy Markdown

m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants