Fix intermittent import failure for firmware 1.15C#7
Open
chackneyrules wants to merge 1 commit into
Open
Conversation
Owner
|
I don't have this OS version yet, so I can't check it... I'll review this when get a copy. |
Owner
|
I have it on authority from Elektron that this is not a change in how SysEx works with 1.15C, and that all the patterns should be sent. If some aren't received, it isn't because they were empty, it is because of the on-going problems with OSes and Browsers handling SysEx > 64k bytes. Therefore, I feel this patch is misleading in that some users will things have worked, but in fact they have not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
Firmware 1.15C does not send a SysEx message for every pattern slot — it omits empty/unused patterns. The app expects all 128
DTPatternKitResponsemessages, leaving any unoccupied slot asNothingin the patterns bank.testAllTherethen returnsTestFail, which aborts the import entirely.This change makes the missing-patterns check return
TestWarn ()instead ofTestFail, consistent with how missing sounds are already handled. The import succeeds, the user sees a warning, and the empty pattern slots remain empty (which is correct — they were empty on the device).missingSamplesis intentionally left asTestFailsince the sample pool arrives in a singleProjectSettingsSysEx and can never be partially missing.