Skip to content

Test TCP connections in CI too#31

Merged
mzabani merged 4 commits into
masterfrom
test-tcp-connections-too
Jul 2, 2026
Merged

Test TCP connections in CI too#31
mzabani merged 4 commits into
masterfrom
test-tcp-connections-too

Conversation

@mzabani

@mzabani mzabani commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Previously we only tested Unix Domain sockets in CI, but not TCP. Was I hoping I would be able to run Darwin tests in parallel, I wonder? Or did I run into the bug recently fixed by a contributor? Not sure. In any case, we don't run Darwin tests in parallel because different instances of postgres would compete to listen on the same port (no Nix sandboxing in Darwin), which would make them fail.

After a recent PR, it became clear to me that we lack tests with TCP. So we need to test it in the pipeline as well (also because cancellation requests reuse the connected-to address, so this is not something that only matters as far as "connection is established, everything now behaves the same"!).

In fact, this reproduces the bug the PR above fixes, namely the following error:

       >   To rerun use: --match "/Transaction/Hpgsql.Transaction/withTransaction issues ROLLBACK when the inner action throws a synchronous exception/" --seed 736461944
       >
       >   TransactionSpec.hs:31:3: 
       >   105) Transaction.Hpgsql.Transaction withTransaction lets irrecoverable errors propagate
       >        uncaught exception: IrrecoverableHpgsqlError
       >        IrrecoverableHpgsqlError {hpgsqlDetails = "An inner exception was thrown", innerException = Just user error (Internal error in hpgsql's recvNonBlocking), relatedStatement = Nothing}
       >
       >   To rerun use: --match "/Transaction/Hpgsql.Transaction/withTransaction lets irrecoverable errors propagate/" --seed 736461944

@mzabani mzabani changed the title Test TCP connections too Test TCP connections in CI too Jul 2, 2026
@mzabani
mzabani force-pushed the test-tcp-connections-too branch from d4d0c9d to 99e52ae Compare July 2, 2026 20:43
@mzabani
mzabani marked this pull request as ready for review July 2, 2026 21:32
@mzabani
mzabani merged commit 967aab2 into master Jul 2, 2026
3 checks passed
@mzabani
mzabani deleted the test-tcp-connections-too branch July 2, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant