Test TCP connections in CI too#31
Merged
Merged
Conversation
mzabani
force-pushed
the
test-tcp-connections-too
branch
from
July 2, 2026 20:43
d4d0c9d to
99e52ae
Compare
This reverts commit 99e52ae.
mzabani
marked this pull request as ready for review
July 2, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we only tested Unix Domain sockets in CI, but not TCP. Was I hoping I would be able to run Darwin tests in parallel, I wonder? Or did I run into the bug recently fixed by a contributor? Not sure. In any case, we don't run Darwin tests in parallel because different instances of postgres would compete to listen on the same port (no Nix sandboxing in Darwin), which would make them fail.
After a recent PR, it became clear to me that we lack tests with TCP. So we need to test it in the pipeline as well (also because cancellation requests reuse the connected-to address, so this is not something that only matters as far as "connection is established, everything now behaves the same"!).
In fact, this reproduces the bug the PR above fixes, namely the following error: