Performance improvement: do more work per buffer access#26
Merged
Conversation
This barely gives a perf improvement, actually.
mzabani
marked this pull request as ready for review
June 25, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing a ~15.4% reduction in run time materializing rows with this change.
The main change is once we extract from the IORef buffer, we now parse as many DataRows at once as we can, instead of parsing at most one DataRow per buffer access.
max_mem_in_use_bytes does go up a few MB in some benchmarks because of course we materialize more rows at once - but that's still a very worthy tradeoff.