Add static_crt option to cpp_build::Config#114
Merged
ogoffart merged 1 commit intomystor:masterfrom Sep 23, 2025
emuell:master
Merged
Add static_crt option to cpp_build::Config#114ogoffart merged 1 commit intomystor:masterfrom emuell:master
static_crt option to cpp_build::Config#114ogoffart merged 1 commit intomystor:masterfrom
emuell:master
Conversation
- option is directly passed to cc and thus behaves exactly as it does in the cc crate
Collaborator
|
Thanks for the patch. Note that there is also a From implementation from the cc::Build : https://docs.rs/cpp_build/latest/cpp_build/struct.Config.html#impl-From%3CBuild%3E-for-Config |
Contributor
Author
|
Missed the From impl. That indeed would also have done the job. Thanks. It's probably worth adding a "Config::from" constructor, which would make it more obvious in the docs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes ugly workarounds like passing
/MDas flags obsolete, which will trigger a warning as this will override the existing/MXflags initially set by the cc crate.