Fix panics while searching type comments in function with syntax error - #78
Merged
Conversation
JukkaL
approved these changes
Aug 21, 2026
JukkaL
left a comment
JukkaL
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just some ideas about additional test cases.
| #[test] | ||
| fn test_syntax_error_broken_args() { | ||
| // Test that we do not panic on invalid function arguments. | ||
| let source = "def f(x, (y, z)): pass\n"; |
Contributor
There was a problem hiding this comment.
Test also case where the invalid function definition is not the first thing in the file, e.g. there is another valid function definition on a previous line.
| #[test] | ||
| fn test_syntax_error_empty_func() { | ||
| // Test that we do not panic on invalid function definition. | ||
| let text = "def hello()\n pass\n"; |
Contributor
There was a problem hiding this comment.
Test also case where the invalid function definition is not the first thing in the file, e.g. there is another valid function definition on a previous line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes panics found in python/mypy#21823
cc @JukkaL