Skip to content

Refactor access rule evaluation for ReadWrite rights #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jurretanjamx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor access rule evaluation for ReadWrite rights #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions rules/002_domain_model/002_0008_avoid_read_write_default_access_rule.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,21 @@ allow if count(errors) == 0
errors contains error if {
entity := input.Entities[_]
entity_name := entity.Name
roles := entity.AccessRules[_].AllowedModuleRoles
role_names := [name | role := roles[_]; parts := split(role, "."); name := parts[count(parts) - 1]]
roles_list := concat(", ", role_names)

# Check for ReadWrite access
entity.AccessRules[_].DefaultMemberAccessRights == "ReadWrite"
# Bind the specific access rule we are evaluating
access_rule := entity.AccessRules[_]

# Only consider access rules with ReadWrite default rights
access_rule.DefaultMemberAccessRights == "ReadWrite"

# Now collect roles only from THIS access_rule
roles := access_rule.AllowedModuleRoles
role_names := [name |
role := roles[_]
parts := split(role, ".")
name := parts[count(parts) - 1]
]
roles_list := concat(", ", role_names)

error := sprintf(
"[%v, %v, %v] ReadWrite access rules found in entity %v for roles %v",
Expand Down