feat(Ghost): allow recording object ghosts - #129
Merged
Merged
Conversation
abart27
requested changes
Aug 27, 2026
abart27
left a comment
abart27
left a comment
Member
There was a problem hiding this comment.
Oh sorry I only saw this so late. LGTM, just small things
Member
Author
|
Thanks for the review, if you want you can merge this then, but it's obviously not very useful without FramePerfection/STROOP/pull/60 being merged, and I don't know yet when I will get around to that. |
FramePerfection
added a commit
to FramePerfection/STROOP
that referenced
this pull request
Sep 18, 2026
This modifies the ghost hack and STROOP behavior to allow rendering arbitrary objects as specified in an extended ghost file format. Also see mupen64/SM64LuaRedux#129 for how to record such a ghost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This alters the ghost recording to be able to capture arbitrary objects insead of Mario by extending the ghost file format and introducing an input box that allows specifying the object address.
Also see FramePerfection/STROOP#60.