Repository navigation
CI: fix the two flaky macOS checks (e2e prompt target, bridge backlog) - #12
Merged
Merged
Conversation
After the approval check was fixed, main's CI failed the credentials check
the same way: its evaluation landed in a stale target for the prompt URL and
returned nothing ('reading origin' of undefined). All prompt reads and
clicks now go through evaluateInLive with a readiness guard, so a target
that has not run prompt.js is skipped instead of answered.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The 120-peer stress check failed in CI with peer 64 refused: the socket's listen backlog was 64, and a burst of connections outran accept() on a busy runner. Use SOMAXCONN (kern.ipc.somaxconn, 128 by default), the most macOS will queue anyway. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The Linux job hung for 30 minutes: a stale prompt target accepted the DevTools socket and never replied, and the helper waited on it forever. Each evaluation now resolves null on error, close, or two seconds of silence. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two checks made the macOS CI job flaky:
main's CI (dc4fd0b) failed the credentials check instead:Cannot read properties of undefined (reading 'origin'). Same race: the evaluation landed in a stale DevTools target for the prompt URL, which returned nothing. All prompt reads and clicks now go throughevaluateInLivewith a readiness guard, so a target that has not runprompt.jsis skipped. 14/14 locally, three runs in a row.accept()on a busy runner. This is a real limit, not only a test one: enough agents starting at once would hit it. The backlog is nowSOMAXCONN(kern.ipc.somaxconn, 128 by default), the most macOS will queue anyway. Passes 3/3 locally.🤖 Generated with Claude Code