fix(desktop): hold the Clerk canary until it can actually build - #11
Merged
Merged
Conversation
Upstream's passkey fix brought @clerk/electron 0.0.34-canary and passkeys 0.0.4-canary. Neither can build here: the published native tarballs are 1 KB with no .node binary, and all six canary packages fall inside the repo's minimumReleaseAge policy, so pnpm install refuses the lockfile on every fleet machine. Pins back to @clerk/electron 0.0.24 and passkeys 0.0.3, and drops the test that uses the 0.0.4-only conditionalUI argument. Upstream's actual fix - the pinned __internal_clerkUIVersion - is a runtime string and stays. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
sheehanmunim
added a commit
that referenced
this pull request
Sep 10, 2026
MIT permits redistribution under other terms, so the work as a whole is now Apache-2.0. What MIT does not permit is dropping its copyright notice: T3 Code's code is most of this repository and its notice has to travel with it, so upstream's MIT text stays as LICENSE-MIT and NOTICE records why both files are here. The comparison table now lists only differences. Nine rows had a tick in both columns, which is not a comparison — drag-to-reorder, PDF attachments, cookie import, tool-activity grouping, composer drawers, preview viewport, file-chip reveal, macOS editor discovery and pull request stacks. Every one of those except the stacks already runs T3 Code's implementation rather than the fork's; the sidebar drag modules, in particular, are byte-identical upstream. Also restores `electronPasskeys.test.ts`, dropped in #11 when the Clerk canary could not build and never brought back after the catalog caught up. With it there is no upstream file this fork is missing. Also removes what should never have been committed, by this repository's own rules: `.github/pr-assets/`, three agent scratch files, and an `undefined/` directory a cookie-import test wrote a Firefox profile into. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Reverted the Clerk canary bump that arrived with upstream's passkey fix:
@clerk/electronback to0.0.24,@clerk/electron-passkeys(and its platform packages) back to0.0.3electronPasskeys.test.ts, which exercises theconditionalUIargument only the 0.0.4 SDK has. It returns with the bump.Why
Two independent blockers, both fatal to a desktop build:
@clerk/electron-passkeys-darwin-arm64@0.0.4-canary.v20260819050620is a 1 KB tarball containingpackage.jsonandLICENSE— no.node. Staging fails withClerkPasskeyNativePackageMissingErrorand the Mac build dies.minimumReleaseAgewindow, sopnpm installrefuses the lockfile on every fleet machine.@clerk/electron@0.0.34-canarypeer-requires the broken passkeys build, so pinning only the natives was not enough. Upstream's actual behavioural fix — the pinned__internal_clerkUIVersion— is a runtime string and stays.Checks
@clerk/electron-passkeys-darwin-arm64@0.0.3resolves its.nodeagain, which is what the desktop build stages