Skip to content

Implementation of reading direct qasm files#450

Open
Marerido wants to merge 10 commits into
munich-quantum-toolkit:mainfrom
Marerido:input_qasm
Open

Implementation of reading direct qasm files#450
Marerido wants to merge 10 commits into
munich-quantum-toolkit:mainfrom
Marerido:input_qasm

Conversation

@Marerido
Copy link
Copy Markdown

@Marerido Marerido commented Jun 4, 2026

Description

Please include a summary of the change and, if applicable, which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #(issue)

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • I have disclosed the use of AI tools in the PR description as per our AI Usage Guidelines.
  • AI-assisted commits include an Assisted-by: [Model Name] via [Tool Name] footer.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

@Marerido Marerido closed this Jun 4, 2026
@Marerido Marerido reopened this Jun 4, 2026
@aaronleesander
Copy link
Copy Markdown
Member

@Marerido Can you move the bulk of the implementation to something like src/digital/utils as qasm_utils.py? Then if a filepath is input into the equivalence checker or simulator, it directs to a function from that file.

Also, the pre-commit is a step with ruff/ty that checks the style and formatting of your code. You can run this locally as well to go through each individual error (I guess just docs for now).

The tests may be failing because of an import, or it could be that the CI online doesn't have the correct imports due to the package configuration. I can look at it later if you can't figure it out.

@aaronleesander aaronleesander self-requested a review June 5, 2026 08:52
@aaronleesander aaronleesander added the feature New feature or request label Jun 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants