Test updates for Supernova release - #295
Conversation
Coverage reportClick to see where and how coverage changed
The report is truncated to 25 files out of 63. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull request overview
Updates network interaction tests to align with the “Supernova” devnet behavior by adjusting expected network config values, enabling previously skipped simulation tests, and tuning awaiter timings used in on-network tests.
Changes:
- Update
round_durationexpectations in API/Proxy provider network config tests. - Enable
simulate_transactiontests and adjust gas limits used for simulation calls. - Tighten polling/timeout intervals in awaiter network interaction tests and adjust test wallet usage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
multiversx_sdk/network_providers/transaction_awaiter_test.py |
Updates polling/timeout settings for network interaction awaiter tests. |
multiversx_sdk/network_providers/proxy_network_provider_test.py |
Updates round_duration expectation, enables simulation test, and adjusts simulation gas limit. |
multiversx_sdk/network_providers/api_network_provider_test.py |
Updates round_duration expectation, enables simulation test, and adjusts simulation gas limit. |
multiversx_sdk/network_providers/account_awaiter_test.py |
Switches wallet used in timeout test and tightens polling/timeout intervals. |
Suppressed comments (2)
multiversx_sdk/network_providers/account_awaiter_test.py:94
- This timeout test sends a transaction to
boband then waits forbob's balance to increase by exactlyvalue. If the transfer is processed quickly enough, the condition can become true and the test will fail intermittently (especially with a short timeout / only 1 retry). To make the test deterministic, ensure the condition cannot be satisfied by this transaction (e.g., expect a different delta).
watcher = AccountAwaiter(
fetcher=api,
polling_interval_in_milliseconds=600,
timeout_interval_in_milliseconds=1000,
)
multiversx_sdk/network_providers/transaction_awaiter_test.py:130
- The timeout assertion currently depends on the transaction reaching a specific status ("failed"). If the transaction fails for any reason (e.g., transient network issues, nonce/balance issues), the condition can become true and the test will stop timing out, making it flaky. Prefer a condition that is guaranteed to remain false so the test always exercises the timeout path.
api = ApiNetworkProvider("https://devnet-api.multiversx.com")
watcher = TransactionAwaiter(
fetcher=api,
polling_interval_in_milliseconds=100,
timeout_interval_in_milliseconds=1000,
)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| proxy = ProxyNetworkProvider("https://devnet-api.multiversx.com") | ||
| watcher = TransactionAwaiter( | ||
| proxy, polling_interval_in_milliseconds=6000, timeout_interval_in_milliseconds=30000 | ||
| proxy, polling_interval_in_milliseconds=1000, timeout_interval_in_milliseconds=10000 | ||
| ) |
| grace = load_wallets()["grace"] | ||
| alice_address = Address.new_from_bech32(grace.label) | ||
| bob = Address.new_from_bech32("erd1spyavw0956vq68xj8y4tenjpq2wd5a9p2c6j8gsz7ztyrnpxrruqzu66jx") | ||
|
|
e4ee555
No description provided.