Skip to content

Test updates for Supernova release - #295

Merged
popenta merged 5 commits into
mainfrom
tests-updates-supernova
Aug 24, 2026
Merged

Test updates for Supernova release#295
popenta merged 5 commits into
mainfrom
tests-updates-supernova

Conversation

@popenta

@popenta popenta commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@popenta popenta self-assigned this Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  multiversx_sdk/abi
  abi.py
  bigint_value.py
  bool_value.py
  bytes_value.py
  code_metadata_value.py
  enum_value.py
  interface.py
  option_value.py
  optional_value.py
  small_int_values.py
  multiversx_sdk/core
  address.py
  errors.py
  interfaces.py
  transaction.py
  transaction_computer.py
  multiversx_sdk/network_providers
  api_network_provider.py
  config.py
  interface.py
  proxy_network_provider.py
  resources.py
  transaction_awaiter.py
  multiversx_sdk/testutils
  mock_network_provider.py
  multiversx_sdk/wallet
  interfaces.py
  mnemonic.py
  user_keys.py
Project Total  

The report is truncated to 25 files out of 63. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

AdoAdoAdo
AdoAdoAdo previously approved these changes Aug 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates network interaction tests to align with the “Supernova” devnet behavior by adjusting expected network config values, enabling previously skipped simulation tests, and tuning awaiter timings used in on-network tests.

Changes:

  • Update round_duration expectations in API/Proxy provider network config tests.
  • Enable simulate_transaction tests and adjust gas limits used for simulation calls.
  • Tighten polling/timeout intervals in awaiter network interaction tests and adjust test wallet usage.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
multiversx_sdk/network_providers/transaction_awaiter_test.py Updates polling/timeout settings for network interaction awaiter tests.
multiversx_sdk/network_providers/proxy_network_provider_test.py Updates round_duration expectation, enables simulation test, and adjusts simulation gas limit.
multiversx_sdk/network_providers/api_network_provider_test.py Updates round_duration expectation, enables simulation test, and adjusts simulation gas limit.
multiversx_sdk/network_providers/account_awaiter_test.py Switches wallet used in timeout test and tightens polling/timeout intervals.
Suppressed comments (2)

multiversx_sdk/network_providers/account_awaiter_test.py:94

  • This timeout test sends a transaction to bob and then waits for bob's balance to increase by exactly value. If the transfer is processed quickly enough, the condition can become true and the test will fail intermittently (especially with a short timeout / only 1 retry). To make the test deterministic, ensure the condition cannot be satisfied by this transaction (e.g., expect a different delta).
        watcher = AccountAwaiter(
            fetcher=api,
            polling_interval_in_milliseconds=600,
            timeout_interval_in_milliseconds=1000,
        )

multiversx_sdk/network_providers/transaction_awaiter_test.py:130

  • The timeout assertion currently depends on the transaction reaching a specific status ("failed"). If the transaction fails for any reason (e.g., transient network issues, nonce/balance issues), the condition can become true and the test will stop timing out, making it flaky. Prefer a condition that is guaranteed to remain false so the test always exercises the timeout path.
        api = ApiNetworkProvider("https://devnet-api.multiversx.com")
        watcher = TransactionAwaiter(
            fetcher=api,
            polling_interval_in_milliseconds=100,
            timeout_interval_in_milliseconds=1000,
        )

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 76 to 79
proxy = ProxyNetworkProvider("https://devnet-api.multiversx.com")
watcher = TransactionAwaiter(
proxy, polling_interval_in_milliseconds=6000, timeout_interval_in_milliseconds=30000
proxy, polling_interval_in_milliseconds=1000, timeout_interval_in_milliseconds=10000
)
Comment on lines +85 to 88
grace = load_wallets()["grace"]
alice_address = Address.new_from_bech32(grace.label)
bob = Address.new_from_bech32("erd1spyavw0956vq68xj8y4tenjpq2wd5a9p2c6j8gsz7ztyrnpxrruqzu66jx")

stefangutica
stefangutica previously approved these changes Aug 21, 2026
axenteoctavian
axenteoctavian previously approved these changes Aug 21, 2026
@popenta
popenta merged commit a3e80ef into main Aug 24, 2026
8 of 9 checks passed
@popenta
popenta deleted the tests-updates-supernova branch August 24, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants