remove request duplicates - #7972
Merged
AdoAdoAdo merged 2 commits intoAug 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces duplicate network requests during syncing by (1) gating the sync-stuck watchdog when there is a known backlog already handled by normal sync, and (2) coalescing concurrent “equivalent proof by nonce” requests so only one in-flight network request is performed per nonce+shard key. It also adds targeted tests to validate both behaviors.
Changes:
- Gate
shouldTryToRequestHeaders()for unsynchronized nodes whenProbableHighestNonce() > currentCommittedNonce()to avoid watchdog-triggered duplicate header requests. - Add in-flight coalescing for
RequestEquivalentProofByNonceForEpoch()via a per-key reservation map to suppress duplicate proof requests. - Add tests covering watchdog gating and proof-request coalescing behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| process/sync/resyncRecovery_test.go | Adds tests for watchdog gating behavior and lookahead proof-request windowing. |
| process/sync/baseSync.go | Gates watchdog header requests for unsynchronized nodes when a backlog is already known. |
| dataRetriever/requestHandlers/requestHandler.go | Adds in-flight deduplication for equivalent-proof-by-nonce requests and refactors request flow. |
| dataRetriever/requestHandlers/requestHandler_test.go | Adds concurrency tests ensuring proof-by-nonce requests are coalesced and reservations are released. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ssd04
approved these changes
Aug 21, 2026
raduchis
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?