Skip to content

refactor cross-header settlement checks to use a unified function - #7971

Open
AdoAdoAdo wants to merge 6 commits into
rc/supernovafrom
refactor-contended-headers-gate
Open

refactor cross-header settlement checks to use a unified function#7971
AdoAdoAdo wants to merge 6 commits into
rc/supernovafrom
refactor-contended-headers-gate

Conversation

@AdoAdoAdo

Copy link
Copy Markdown
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors cross-header settlement gating to consistently honor epoch and round activation.

Changes:

  • Adds a shared settlement activation helper.
  • Applies round-aware gating across tracking and block-processing paths.
  • Expands activation tests and updates shard ID parsing.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Summary
testscommon/enableRoundsHandlerStub.go Adds configurable round handler test stub.
process/track/crossHeaderSettlement_test.go Updates settlement test fixtures.
process/track/contendedHeadersProofPuller.go Filters inactive settlement candidates.
process/track/contendedHeadersProofPuller_test.go Tests round activation filtering.
process/track/blockProcessor.go Applies unified gating; critical nil round-handler validation issue remains.
process/track/blockProcessor_test.go Adds activation-state coverage.
process/block/shardblockProposal_test.go Updates shard proposal tests.
process/block/shardblock_test.go Adds round activation coverage.
process/block/metablockProposal.go Applies gating during proposal selection.
process/block/metablockProposal_test.go Expands proposal-path coverage.
process/block/metablock_test.go Adds round activation scenarios.
process/block/baseProcess.go Uses unified settlement gating.
epochStart/bootstrap/fromLocalStorage.go Parses shard IDs as unsigned values.
common/common.go Adds unified gating; nil round-handler handling can cause a panic.
common/common_test.go Tests activation combinations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread common/common.go
Comment thread process/track/blockProcessor.go
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.71%. Comparing base (707263a) to head (a599f7b).

Files with missing lines Patch % Lines
process/track/contendedHeadersProofPuller.go 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           rc/supernova    #7971   +/-   ##
=============================================
  Coverage         77.70%   77.71%           
=============================================
  Files               893      893           
  Lines            129697   129731   +34     
=============================================
+ Hits             100784   100815   +31     
  Misses            22325    22325           
- Partials           6588     6591    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdoAdoAdo
AdoAdoAdo marked this pull request as ready for review August 21, 2026 08:05
Comment thread process/track/contendedHeadersProofPuller.go
ssd04
ssd04 previously approved these changes Aug 21, 2026
miiu96
miiu96 previously approved these changes Aug 21, 2026
@AdoAdoAdo
AdoAdoAdo dismissed stale reviews from miiu96 and ssd04 via a599f7b August 21, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants