refactor cross-header settlement checks to use a unified function - #7971
Open
AdoAdoAdo wants to merge 6 commits into
Open
refactor cross-header settlement checks to use a unified function#7971AdoAdoAdo wants to merge 6 commits into
AdoAdoAdo wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors cross-header settlement gating to consistently honor epoch and round activation.
Changes:
- Adds a shared settlement activation helper.
- Applies round-aware gating across tracking and block-processing paths.
- Expands activation tests and updates shard ID parsing.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Summary |
|---|---|
testscommon/enableRoundsHandlerStub.go |
Adds configurable round handler test stub. |
process/track/crossHeaderSettlement_test.go |
Updates settlement test fixtures. |
process/track/contendedHeadersProofPuller.go |
Filters inactive settlement candidates. |
process/track/contendedHeadersProofPuller_test.go |
Tests round activation filtering. |
process/track/blockProcessor.go |
Applies unified gating; critical nil round-handler validation issue remains. |
process/track/blockProcessor_test.go |
Adds activation-state coverage. |
process/block/shardblockProposal_test.go |
Updates shard proposal tests. |
process/block/shardblock_test.go |
Adds round activation coverage. |
process/block/metablockProposal.go |
Applies gating during proposal selection. |
process/block/metablockProposal_test.go |
Expands proposal-path coverage. |
process/block/metablock_test.go |
Adds round activation scenarios. |
process/block/baseProcess.go |
Uses unified settlement gating. |
epochStart/bootstrap/fromLocalStorage.go |
Parses shard IDs as unsigned values. |
common/common.go |
Adds unified gating; nil round-handler handling can cause a panic. |
common/common_test.go |
Tests activation combinations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/supernova #7971 +/- ##
=============================================
Coverage 77.70% 77.71%
=============================================
Files 893 893
Lines 129697 129731 +34
=============================================
+ Hits 100784 100815 +31
Misses 22325 22325
- Partials 6588 6591 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AdoAdoAdo
marked this pull request as ready for review
August 21, 2026 08:05
ssd04
reviewed
Aug 21, 2026
ssd04
previously approved these changes
Aug 21, 2026
miiu96
previously approved these changes
Aug 21, 2026
remove request duplicates
ssd04
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?