fixes stall on snapshot - #7949
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/recon-by-meta #7949 +/- ##
======================================================
+ Coverage 77.59% 77.70% +0.10%
======================================================
Files 892 892
Lines 128225 128882 +657
======================================================
+ Hits 99498 100146 +648
+ Misses 22202 22194 -8
- Partials 6525 6542 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… and update test cases
Contributor
Author
fixed |
… retries exceeded
sstanculeanu
reviewed
Aug 4, 2026
| rootHash := lastExecResult.GetRootHash() | ||
| _, err = boot.accounts.GetTrie(rootHash) | ||
| if err != nil { | ||
| boot.statusHandler.Increment(common.MetricNumRollBacksRefusedMissingState) |
Collaborator
There was a problem hiding this comment.
MetricNumRollBacksRefusedMissingState is incremented but not registered inside metrics.go
| var ErrInvalidIdentifier = errors.New("invalid identifier") | ||
|
|
||
| // ErrInvalidSnapshotsGoroutinesPerCore signals that the configured snapshots goroutines per core is invalid | ||
| var ErrInvalidSnapshotsGoroutinesPerCore = errors.New("invalid snapshots goroutines per core, must be at least 1") |
Collaborator
There was a problem hiding this comment.
Suggested change
| var ErrInvalidSnapshotsGoroutinesPerCore = errors.New("invalid snapshots goroutines per core, must be at least 1") | |
| var ErrInvalidSnapshotsGoroutinesPerCore = errors.New("invalid snapshots goroutines per core") |
and add the extra info on return fmt
sstanculeanu
approved these changes
Aug 7, 2026
raduchis
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?