Skip to content

add guard to avoid underflow and deleting needed nodesConfig #7908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdoAdoAdo merged 2 commits into from
Jul 9, 2026
Merged

add guard to avoid underflow and deleting needed nodesConfig #7908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5537de
add guard to avoid underflow and deleting needed nodesConfig
BeniaminDrasovean Jul 9, 2026
57bfb43
Merge branch 'feat/testnet-fixes' into nodes-coordinator-underflow-fix
AdoAdoAdo Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sharding/nodesCoordinator/indexHashedNodesCoordinatorLite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,15 @@ func (ihnc *indexHashedNodesCoordinator) IsEpochInConfig(epoch uint32) bool {
}

func (ihnc *indexHashedNodesCoordinator) removeOlderEpochs(epoch uint32, maxDelta uint32) {
if epoch < maxDelta {
return
}
epochToRemove := epoch - maxDelta

ihnc.mutNodesConfig.Lock()
if len(ihnc.nodesConfig) >= int(maxDelta) {
for currEpoch := range ihnc.nodesConfig {
if currEpoch <= epoch-maxDelta {
if currEpoch <= epochToRemove {
delete(ihnc.nodesConfig, currEpoch)
}
}
Expand Down
43 changes: 43 additions & 0 deletions sharding/nodesCoordinator/indexHashedNodesCoordinatorLite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,3 +187,46 @@ func TestIndexHashedNodesCoordinator_IsEpochInConfig(t *testing.T) {
exists = ihnc.IsEpochInConfig(epoch + 1)
assert.False(t, exists)
}

func TestIndexHashedNodesCoordinator_RemoveOlderEpochsShouldNotRemoveWhenEpochIsLessThanMaxDelta(t *testing.T) {
t.Parallel()

arguments := createArguments()
ihnc, err := NewIndexHashedNodesCoordinator(arguments)
require.Nil(t, err)

ihnc.nodesConfig[1] = &epochNodesConfig{}
ihnc.nodesConfig[2] = &epochNodesConfig{}
ihnc.nodesConfig[3] = &epochNodesConfig{}

ihnc.removeOlderEpochs(3, nodesCoordinatorStoredEpochs)

require.Len(t, ihnc.nodesConfig, 4)
require.Contains(t, ihnc.nodesConfig, uint32(0))
require.Contains(t, ihnc.nodesConfig, uint32(1))
require.Contains(t, ihnc.nodesConfig, uint32(2))
require.Contains(t, ihnc.nodesConfig, uint32(3))
}

func TestIndexHashedNodesCoordinator_RemoveOlderEpochsShouldRemoveOnlyOlderEpochs(t *testing.T) {
t.Parallel()

arguments := createArguments()
ihnc, err := NewIndexHashedNodesCoordinator(arguments)
require.Nil(t, err)

ihnc.nodesConfig[0] = &epochNodesConfig{}
ihnc.nodesConfig[1] = &epochNodesConfig{}
ihnc.nodesConfig[2] = &epochNodesConfig{}
ihnc.nodesConfig[3] = &epochNodesConfig{}
ihnc.nodesConfig[4] = &epochNodesConfig{}

ihnc.removeOlderEpochs(4, nodesCoordinatorStoredEpochs)

require.Len(t, ihnc.nodesConfig, 4)
require.NotContains(t, ihnc.nodesConfig, uint32(0))
require.Contains(t, ihnc.nodesConfig, uint32(1))
require.Contains(t, ihnc.nodesConfig, uint32(2))
require.Contains(t, ihnc.nodesConfig, uint32(3))
require.Contains(t, ihnc.nodesConfig, uint32(4))
}
Loading