Subrounds timing by epoch by sstanculeanu · Pull Request #7881 · multiversx/mx-chain-go

sstanculeanu · 2026-06-16T12:48:34Z

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

codecov · 2026-06-16T12:58:50Z

Codecov Report

❌ Patch coverage is 94.26752% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.70%. Comparing base (4884240) to head (1e36a24).
⚠️ Report is 14 commits behind head on feat/testnet-fixes.

Files with missing lines	Patch %	Lines
consensus/spos/bls/proxy/subroundsHandler.go	86.53%	4 Missing and 3 partials ⚠️
common/configs/commonConfigs.go	96.00%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           feat/testnet-fixes    #7881    +/-   ##
====================================================
  Coverage               77.69%   77.70%            
====================================================
  Files                     885      885            
  Lines                  125677   125781   +104     
====================================================
+ Hits                    97649    97742    +93     
- Misses                  21562    21570     +8     
- Partials                 6466     6469     +3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ssd04 · 2026-06-16T14:29:24Z

*optional: keep the constants for v1, and update the factory only for v2

tried to keep similar flow

ssd04 · 2026-06-16T14:31:41Z

+                SubroundStartStartTime = 0.0,
+                SubroundStartEndTime = 0.05,
+                SubroundBlockStartTime = 0.05,
+                SubroundBlockEndTime = 0.25,
+                SubroundSignatureStartTime = 0.25,


*optional: remove Subround prefix

I don't think it would be clear enough, StartStartTime, BlockStartTime, etc

…-chain-go into subrounds-timing-by-epoch

AdoAdoAdo · 2026-06-29T10:17:37Z

 	currentEpoch := headerHandler.GetEpoch()

-	sigSubroundEndTime := time.Duration(float64(sr.RoundHandler().TimeDuration()) * srSignatureEndTime)
+	sigSubroundEndTime := time.Duration(sr.EndTime())


I think this needs to be set back to the srSignatureEndTime, as here we are triggering optimistically the signing that ends at the end of subround signature.

AdoAdoAdo · 2026-06-29T10:22:46Z

+        },
+        {
+            EnableEpoch = 1,
+            NumRoundsToWaitBeforeSignalingChronologyStuck = 10,


if this is identical with the previous config, we can probably remove it from the config?

AdoAdoAdo · 2026-06-29T10:23:23Z

+            }
+        },
+        {
+            EnableEpoch = 2,


For Supernova I think we need also the round activation for the timing change - so only on both conditions we should change the timing there.

AdoAdoAdo · 2026-06-29T10:34:10Z

    ConsensusConfigsByEpoch = [
-        { EnableEpoch = 0, NumRoundsToWaitBeforeSignalingChronologyStuck = 10 },
-        { EnableEpoch = 2, NumRoundsToWaitBeforeSignalingChronologyStuck = 100 },
+        {


can you create a validation func for each epoch config where it is loaded into the component requiring it/init?
e.g

non negative values

every subround has a start and end value, start<end

no overlapping range between subrounds

increasing values between subrounds (start subround n+1 > end subround n)

max value < 1.

ssd04 · 2026-06-29T14:55:10Z

+	round := uint64(fct.consensusCore.RoundHandler().Index())
+	timing := fct.commonConfigsHandler.GetSubroundsTimingByRound(round)


in RoundConfirmed we are setting timings based on received round, and here based on current consensus round, i'm thinking if they might not match; if RoundConfirmed is triggered from the processing flow, then they might be fetched for different rounds

good catch, fixed

Copilot

Pull request overview

This PR introduces round-based consensus timing configuration, allowing subround start/end ratios and processing thresholds to be selected by round boundary and applied to BLS subround generation (v1/v2), including re-generation when timing boundaries change.

Changes:

Adds ConsensusConfigsByRound and SubroundTiming to the node configuration model and TOML, with validation and getters in the common configs handler.
Updates BLS subround factories (v1/v2) to derive subround timings and processing thresholds from CommonConfigsHandler based on the current round.
Extends the proxy subrounds handler to listen for round changes and re-generate subrounds when the active timing boundary changes; updates related stubs/tests/config fixtures accordingly.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
testscommon/generalConfig.go	Adds default `ConsensusConfigsByRound` to test general config.
testscommon/epochStartConfigsHandlerStub.go	Updates common configs stub creation and adds stub methods for timing-by-round.
testscommon/components/configs.go	Adds default `ConsensusConfigsByRound` to component test config.
node/chainSimulator/components/coreComponents.go	Passes `ConsensusConfigsByRound` into common configs handler construction.
node/chainSimulator/components/coreComponents_test.go	Adds `ConsensusConfigsByRound` to simulator test args.
integrationTests/testProcessorNode.go	Adjusts imports and provides a `RoundNotifierField` in default core components for integration tests.
factory/core/coreComponents.go	Passes `ConsensusConfigsByRound` into common configs handler construction.
factory/consensus/consensusComponents.go	Wires `CommonConfigsHandler` and `RoundNotifier` into consensus component args.
factory/consensus/consensusComponents_test.go	Adds a `RoundChangeNotifier` stub to consensus factory test args.
consensus/spos/bls/v2/subroundBlock.go	Makes signature subround end time configurable via constructor field.
consensus/spos/bls/v2/subroundBlock_test.go	Updates constructor calls to include configured signature subround end time.
consensus/spos/bls/v2/export_test.go	Replaces exported internal constants with test-local config defaults passed into generators.
consensus/spos/bls/v2/constants.go	Removes hardcoded processing/timing constants (now config-driven).
consensus/spos/bls/v2/blsSubroundsFactory.go	Uses `CommonConfigsHandler` timing-by-round to build subrounds (and passes signature end time to block subround).
consensus/spos/bls/v2/blsSubroundsFactory_test.go	Updates factory construction and `GenerateSubrounds` signature; adds tests around passing the round into timing selection.
consensus/spos/bls/v1/export_test.go	Mirrors v2 export_test changes using test-local config defaults.
consensus/spos/bls/v1/constants.go	Removes hardcoded processing/timing constants (now config-driven).
consensus/spos/bls/v1/blsSubroundsFactory.go	Uses `CommonConfigsHandler` timing-by-round to build subrounds and updates `GenerateSubrounds` signature.
consensus/spos/bls/v1/blsSubroundsFactory_test.go	Updates factory construction and `GenerateSubrounds` signature; adds nil-common-configs-handler coverage.
consensus/spos/bls/proxy/subroundsHandler.go	Adds round-change handling to re-generate subrounds when the active timing boundary changes; introduces synchronization/state fields.
consensus/spos/bls/proxy/subroundsHandler_test.go	Updates handler args and adds nil round notifier coverage; adjusts flag checks.
consensus/spos/bls/proxy/errors.go	Adds `ErrNilRoundNotifier`.
consensus/chronology/chronology.go	Removes an outdated TODO comment during Supernova transition handling.
config/config.go	Introduces `ConsensusConfigByRound` + `SubroundTiming` and adds `ConsensusConfigsByRound` to general settings.
common/interface.go	Extends `CommonConfigsHandler` with timing-by-round getters.
common/configs/errors.go	Adds consensus-by-round validation errors.
common/configs/commonConfigs.go	Stores/validates consensus-by-round configs; adds getters for timing and active boundary round.
common/configs/commonConfigs_test.go	Expands tests for consensus-by-round validation and getter behavior.
cmd/node/config/config.toml	Adds `ConsensusConfigsByRound` examples to node config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sstanculeanu · 2026-06-30T11:40:56Z

+// RoundConfirmed is called when a new round is confirmed
+func (s *SubroundsHandler) RoundConfirmed(round uint64, _ uint64) {
+	s.mutReInit.Lock()
+	defer s.mutReInit.Unlock()
+


ssd04 · 2026-06-30T10:02:07Z

no other things from me

sstanculeanu added 2 commits June 16, 2026 15:24

subrounds timings by epoch

9c8165d

handle supernova on subrounds handler

55a0eb3

sstanculeanu self-assigned this Jun 16, 2026

sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Jun 16, 2026

ssd04 reviewed Jun 16, 2026

View reviewed changes

sstanculeanu and others added 3 commits June 19, 2026 17:33

Merge branch 'feat/testnet-fixes' into subrounds-timing-by-epoch

80fb747

Merge branch 'feat/testnet-fixes' of https://github.com/multiversx/mx…

800c713

…-chain-go into subrounds-timing-by-epoch

fix linter

3cf66b3

AdoAdoAdo self-requested a review June 24, 2026 13:47

AdoAdoAdo and others added 2 commits June 29, 2026 11:25

Merge branch 'feat/testnet-fixes' into subrounds-timing-by-epoch

cbdbea3

Merge branch 'feat/testnet-fixes' into subrounds-timing-by-epoch

a13bcea

AdoAdoAdo reviewed Jun 29, 2026

View reviewed changes

fixes after review

9144314

sstanculeanu closed this Jun 29, 2026

sstanculeanu reopened this Jun 29, 2026

Merge branch 'feat/testnet-fixes' into subrounds-timing-by-epoch

b268c03

ssd04 reviewed Jun 29, 2026

View reviewed changes

sstanculeanu added 2 commits June 30, 2026 11:03

fix after review - use round from notifier

03a9146

fix after review - use touple for subrounds timing config

aabaace

AdoAdoAdo previously approved these changes Jun 30, 2026

View reviewed changes

AdoAdoAdo requested a review from Copilot June 30, 2026 09:14

Copilot started reviewing on behalf of AdoAdoAdo June 30, 2026 09:15 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

fixes after copilot

c10f3c4

sstanculeanu dismissed AdoAdoAdo’s stale review via c10f3c4 June 30, 2026 11:40

AdoAdoAdo previously approved these changes Jun 30, 2026

View reviewed changes

fix nonascii

1e36a24

sstanculeanu dismissed AdoAdoAdo’s stale review via 1e36a24 June 30, 2026 11:47

AdoAdoAdo approved these changes Jun 30, 2026

View reviewed changes

ssd04 approved these changes Jun 30, 2026

View reviewed changes

sstanculeanu merged commit f93bba8 into feat/testnet-fixes Jun 30, 2026
11 checks passed

sstanculeanu deleted the subrounds-timing-by-epoch branch June 30, 2026 12:12

		round := uint64(fct.consensusCore.RoundHandler().Index())
		timing := fct.commonConfigsHandler.GetSubroundsTimingByRound(round)

Uh oh!

Conversation

sstanculeanu commented Jun 16, 2026

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Uh oh!

codecov Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ssd04 commented Jun 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jun 16, 2026 •

edited

Loading