Added unbond period metrics - #7847
Merged
Merged
Conversation
sstanculeanu
previously approved these changes
May 14, 2026
ssd04
previously approved these changes
May 14, 2026
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/supernova #7847 +/- ##
=============================================
Coverage 77.53% 77.53%
=============================================
Files 882 882
Lines 124494 124503 +9
=============================================
+ Hits 96527 96538 +11
+ Misses 21556 21552 -4
- Partials 6411 6413 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Run Tests: |
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
sstanculeanu
previously approved these changes
May 20, 2026
ssd04
previously approved these changes
May 20, 2026
| MetricSupernovaEnableEpoch = "erd_supernova_enable_epoch" | ||
|
|
||
| // MetricUnBondPeriod represents the unbond period in rounds from StakingSystemSCConfig | ||
| MetricUnBondPeriod = "erd_un_bond_period" |
There was a problem hiding this comment.
can you use erd_unbond_*? We already have erd_unbond_tokens_v2_enable_epoch
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
raduchistest
approved these changes
May 21, 2026
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
raduchis
approved these changes
May 21, 2026
ssd04
approved these changes
May 21, 2026
sstanculeanu
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?