Feature/implementation tester#345
Merged
Merged
Conversation
maarten-ic
reviewed
Apr 1, 2026
maarten-ic
reviewed
Apr 7, 2026
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Couple of comments, we should probably be close to get this working for a simple case?
IrisvdWerf
commented
Apr 8, 2026
maarten-ic
approved these changes
May 4, 2026
LourensVeen
approved these changes
May 17, 2026
Contributor
LourensVeen
left a comment
LourensVeen
left a comment
There was a problem hiding this comment.
This is looking really nice! I have a few comments for you to consider, but I'm going to mark this Approve and let you decide what to do with them (well, the PROJECT_DIR vs. TESTS_DIR thing in the docs needs to be fixed probably).
maarten-ic
reviewed
May 18, 2026
maarten-ic
reviewed
May 19, 2026
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Couple of comments, let me know if you have any questions about these!
maarten-ic
reviewed
May 19, 2026
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
This should be my final nitpick 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.