fix: Make sort order deterministic#162
Merged
Merged
Conversation
|
Codeowners approval required for this PR: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces unstable sorting (sort.Sort) with stable sorting (sort.Stable) when ordering codeowner rules. This change ensures that the relative order of rules with the same priority is preserved, maintaining the expected "last declared wins" semantics. A new unit test, TestReadLastMatchWinsSamePriority, along with an in-memory file reader helper, has been added to verify this behavior. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Closes #154
Summary / Background
Reverse rule ordering is not being respected due to
sort.Sortnot deterministically retaining reversed ordering. Switch tosort.Stable