Skip to content

fix(shard): apply default runtime identity to any pool image #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graveland merged 2 commits into from
Sep 14, 2026
Merged

fix(shard): apply default runtime identity to any pool image #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
024d9a1
fix(shard): apply default runtime identity to any pool image
graveland Sep 4, 2026
0d5ca87
docs(api): correct RunAsUser/RunAsGroup comments for the new default
graveland Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions api/v1alpha1/common_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,16 +199,21 @@ type ContainerConfig struct {
// +optional
Resources corev1.ResourceRequirements `json:"resources,omitempty"`

// RunAsUser sets the UID for the container process. When unset, Kubernetes
// and the container runtime apply the image's default user.
// Images that declare USER by name may need this set to a numeric UID when
// RunAsNonRoot enforcement is required.
// RunAsUser sets the UID for the container process. For Postgres and
// Multipooler, leaving this unset does not fall back to the image's own
// user: the operator applies its own default numeric UID (shared between
// the two so both can reach PGDATA), because pgctld declares USER
// postgres by name and Kubernetes cannot enforce RunAsNonRoot without a
// numeric UID. A custom image that runs as a different user must set
// this explicitly - including when reusing a PersistentVolume whose data
// is already owned by another UID, since a mismatch there fails the pod
// at startup rather than at scheduling.
// +optional
// +kubebuilder:validation:Minimum=1
RunAsUser *int64 `json:"runAsUser,omitempty"`

// RunAsGroup sets the primary GID for the container process. When unset,
// Kubernetes and the container runtime apply their default group handling.
// RunAsGroup sets the primary GID for the container process. Same
// operator-supplied default and same caveats as RunAsUser.
// +optional
// +kubebuilder:validation:Minimum=0
RunAsGroup *int64 `json:"runAsGroup,omitempty"`
Expand Down
68 changes: 44 additions & 24 deletions config/crd/bases/multigres.com_multigresclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5418,17 +5418,22 @@ spec:
type: object
runAsGroup:
description: |-
RunAsGroup sets the primary GID for the container process. When unset,
Kubernetes and the container runtime apply their default group handling.
RunAsGroup sets the primary GID for the container process. Same
operator-supplied default and same caveats as RunAsUser.
format: int64
minimum: 0
type: integer
runAsUser:
description: |-
RunAsUser sets the UID for the container process. When unset, Kubernetes
and the container runtime apply the image's default user.
Images that declare USER by name may need this set to a numeric UID when
RunAsNonRoot enforcement is required.
RunAsUser sets the UID for the container process. For Postgres and
Multipooler, leaving this unset does not fall back to the image's own
user: the operator applies its own default numeric UID (shared between
the two so both can reach PGDATA), because pgctld declares USER
postgres by name and Kubernetes cannot enforce RunAsNonRoot without a
numeric UID. A custom image that runs as a different user must set
this explicitly - including when reusing a PersistentVolume whose data
is already owned by another UID, since a mismatch there fails the pod
at startup rather than at scheduling.
format: int64
minimum: 1
type: integer
Expand Down Expand Up @@ -5499,17 +5504,22 @@ spec:
type: object
runAsGroup:
description: |-
RunAsGroup sets the primary GID for the container process. When unset,
Kubernetes and the container runtime apply their default group handling.
RunAsGroup sets the primary GID for the container process. Same
operator-supplied default and same caveats as RunAsUser.
format: int64
minimum: 0
type: integer
runAsUser:
description: |-
RunAsUser sets the UID for the container process. When unset, Kubernetes
and the container runtime apply the image's default user.
Images that declare USER by name may need this set to a numeric UID when
RunAsNonRoot enforcement is required.
RunAsUser sets the UID for the container process. For Postgres and
Multipooler, leaving this unset does not fall back to the image's own
user: the operator applies its own default numeric UID (shared between
the two so both can reach PGDATA), because pgctld declares USER
postgres by name and Kubernetes cannot enforce RunAsNonRoot without a
numeric UID. A custom image that runs as a different user must set
this explicitly - including when reusing a PersistentVolume whose data
is already owned by another UID, since a mismatch there fails the pod
at startup rather than at scheduling.
format: int64
minimum: 1
type: integer
Expand Down Expand Up @@ -7913,17 +7923,22 @@ spec:
type: object
runAsGroup:
description: |-
RunAsGroup sets the primary GID for the container process. When unset,
Kubernetes and the container runtime apply their default group handling.
RunAsGroup sets the primary GID for the container process. Same
operator-supplied default and same caveats as RunAsUser.
format: int64
minimum: 0
type: integer
runAsUser:
description: |-
RunAsUser sets the UID for the container process. When unset, Kubernetes
and the container runtime apply the image's default user.
Images that declare USER by name may need this set to a numeric UID when
RunAsNonRoot enforcement is required.
RunAsUser sets the UID for the container process. For Postgres and
Multipooler, leaving this unset does not fall back to the image's own
user: the operator applies its own default numeric UID (shared between
the two so both can reach PGDATA), because pgctld declares USER
postgres by name and Kubernetes cannot enforce RunAsNonRoot without a
numeric UID. A custom image that runs as a different user must set
this explicitly - including when reusing a PersistentVolume whose data
is already owned by another UID, since a mismatch there fails the pod
at startup rather than at scheduling.
format: int64
minimum: 1
type: integer
Expand Down Expand Up @@ -7994,17 +8009,22 @@ spec:
type: object
runAsGroup:
description: |-
RunAsGroup sets the primary GID for the container process. When unset,
Kubernetes and the container runtime apply their default group handling.
RunAsGroup sets the primary GID for the container process. Same
operator-supplied default and same caveats as RunAsUser.
format: int64
minimum: 0
type: integer
runAsUser:
description: |-
RunAsUser sets the UID for the container process. When unset, Kubernetes
and the container runtime apply the image's default user.
Images that declare USER by name may need this set to a numeric UID when
RunAsNonRoot enforcement is required.
RunAsUser sets the UID for the container process. For Postgres and
Multipooler, leaving this unset does not fall back to the image's own
user: the operator applies its own default numeric UID (shared between
the two so both can reach PGDATA), because pgctld declares USER
postgres by name and Kubernetes cannot enforce RunAsNonRoot without a
numeric UID. A custom image that runs as a different user must set
this explicitly - including when reusing a PersistentVolume whose data
is already owned by another UID, since a mismatch there fails the pod
at startup rather than at scheduling.
format: int64
minimum: 1
type: integer
Expand Down
34 changes: 22 additions & 12 deletions config/crd/bases/multigres.com_shards.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2552,17 +2552,22 @@ spec:
type: object
runAsGroup:
description: |-
RunAsGroup sets the primary GID for the container process. When unset,
Kubernetes and the container runtime apply their default group handling.
RunAsGroup sets the primary GID for the container process. Same
operator-supplied default and same caveats as RunAsUser.
format: int64
minimum: 0
type: integer
runAsUser:
description: |-
RunAsUser sets the UID for the container process. When unset, Kubernetes
and the container runtime apply the image's default user.
Images that declare USER by name may need this set to a numeric UID when
RunAsNonRoot enforcement is required.
RunAsUser sets the UID for the container process. For Postgres and
Multipooler, leaving this unset does not fall back to the image's own
user: the operator applies its own default numeric UID (shared between
the two so both can reach PGDATA), because pgctld declares USER
postgres by name and Kubernetes cannot enforce RunAsNonRoot without a
numeric UID. A custom image that runs as a different user must set
this explicitly - including when reusing a PersistentVolume whose data
is already owned by another UID, since a mismatch there fails the pod
at startup rather than at scheduling.
format: int64
minimum: 1
type: integer
Expand Down Expand Up @@ -2632,17 +2637,22 @@ spec:
type: object
runAsGroup:
description: |-
RunAsGroup sets the primary GID for the container process. When unset,
Kubernetes and the container runtime apply their default group handling.
RunAsGroup sets the primary GID for the container process. Same
operator-supplied default and same caveats as RunAsUser.
format: int64
minimum: 0
type: integer
runAsUser:
description: |-
RunAsUser sets the UID for the container process. When unset, Kubernetes
and the container runtime apply the image's default user.
Images that declare USER by name may need this set to a numeric UID when
RunAsNonRoot enforcement is required.
RunAsUser sets the UID for the container process. For Postgres and
Multipooler, leaving this unset does not fall back to the image's own
user: the operator applies its own default numeric UID (shared between
the two so both can reach PGDATA), because pgctld declares USER
postgres by name and Kubernetes cannot enforce RunAsNonRoot without a
numeric UID. A custom image that runs as a different user must set
this explicitly - including when reusing a PersistentVolume whose data
is already owned by another UID, since a mismatch there fails the pod
at startup rather than at scheduling.
format: int64
minimum: 1
type: integer
Expand Down
34 changes: 22 additions & 12 deletions config/crd/bases/multigres.com_shardtemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2137,17 +2137,22 @@ spec:
type: object
runAsGroup:
description: |-
RunAsGroup sets the primary GID for the container process. When unset,
Kubernetes and the container runtime apply their default group handling.
RunAsGroup sets the primary GID for the container process. Same
operator-supplied default and same caveats as RunAsUser.
format: int64
minimum: 0
type: integer
runAsUser:
description: |-
RunAsUser sets the UID for the container process. When unset, Kubernetes
and the container runtime apply the image's default user.
Images that declare USER by name may need this set to a numeric UID when
RunAsNonRoot enforcement is required.
RunAsUser sets the UID for the container process. For Postgres and
Multipooler, leaving this unset does not fall back to the image's own
user: the operator applies its own default numeric UID (shared between
the two so both can reach PGDATA), because pgctld declares USER
postgres by name and Kubernetes cannot enforce RunAsNonRoot without a
numeric UID. A custom image that runs as a different user must set
this explicitly - including when reusing a PersistentVolume whose data
is already owned by another UID, since a mismatch there fails the pod
at startup rather than at scheduling.
format: int64
minimum: 1
type: integer
Expand Down Expand Up @@ -2217,17 +2222,22 @@ spec:
type: object
runAsGroup:
description: |-
RunAsGroup sets the primary GID for the container process. When unset,
Kubernetes and the container runtime apply their default group handling.
RunAsGroup sets the primary GID for the container process. Same
operator-supplied default and same caveats as RunAsUser.
format: int64
minimum: 0
type: integer
runAsUser:
description: |-
RunAsUser sets the UID for the container process. When unset, Kubernetes
and the container runtime apply the image's default user.
Images that declare USER by name may need this set to a numeric UID when
RunAsNonRoot enforcement is required.
RunAsUser sets the UID for the container process. For Postgres and
Multipooler, leaving this unset does not fall back to the image's own
user: the operator applies its own default numeric UID (shared between
the two so both can reach PGDATA), because pgctld declares USER
postgres by name and Kubernetes cannot enforce RunAsNonRoot without a
numeric UID. A custom image that runs as a different user must set
this explicitly - including when reusing a PersistentVolume whose data
is already owned by another UID, since a mismatch there fails the pod
at startup rather than at scheduling.
format: int64
minimum: 1
type: integer
Expand Down
Loading
Loading