fix: do not send request body on GET/HEAD#95
Merged
Conversation
GET requests carried a JSON body ({}), which made forwarding proxies like
privoxy hang: python sends the body in a separate TCP segment that the proxy
does not expect on a GET, so the response never comes back and the request
times out. curl and socks5h are unaffected. Scope the default body and json
content type to body methods only.
Refs work_item 1253
Member
Author
|
Pipeline ID: 1976699 |
cielavenir
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET requests carry a JSON body ({}), which makes forwarding proxies like privoxy hang. Python sends the body in a separate TCP segment that the proxy does not expect on a GET, so the response never comes back and the request times out.
Fix: only attach the default body + json content-type on body methods (POST/PUT/PATCH/DELETE).