[modal] Replace custom findIndexOf with findIndex#48827
Merged
ZeeshanTamboli merged 1 commit intoJul 21, 2026
Merged
Conversation
ZeeshanTamboli
added
scope: modal
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
ZeeshanTamboli
marked this pull request as ready for review
July 18, 2026 12:56
silviuaavram
approved these changes
Jul 21, 2026
ZeeshanTamboli
deleted the
modalmanager-replace-custom-findIndexOf-with-findIndex
branch
July 21, 2026 07:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the custom
findIndexOfhelper inModalManagerwith the nativeArray.prototype.findIndex, simplifying the implementation without changing behavior.