[autocomplete] Prevent crash when rendering cached grouped options#48788
Open
atharva3333 wants to merge 3 commits into
Open
[autocomplete] Prevent crash when rendering cached grouped options#48788atharva3333 wants to merge 3 commits into
atharva3333 wants to merge 3 commits into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
ZeeshanTamboli
added
type: bug
ZeeshanTamboli
changed the title
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
Member
There was a problem hiding this comment.
This works but the fix is a defensive workaround rather than fixing the root issue. With this, when groupBy is active, Autocomplete will silently render a raw option through the ungrouped path. If groupBy is enabled, the list renderer should receive grouped option objects only.
ZeeshanTamboli
added
type: regression
Contributor
Author
|
Sure, I will try fixing the root cause |
Member
@atharva3333 Did you find a solution? |
Contributor
Author
Not yet |
Member
There was a problem hiding this comment.
I believe it is not an issue. I have posted a comment: #48692 (comment). Let's wait for the author's response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48692
Summary
Fixes a regression introduced by #48327 where cached ungrouped options can be rendered after
groupBybecomes active.The grouped rendering path assumed every cached entry had the grouped
{ group, options }shape and attempted to accessoption.options, causing a runtime error when cached raw options were encountered.This change guards the grouped rendering path against cached raw options and adds a regression test covering the reported scenario.