[material-ui][Modal] Add the mountNode prop#40211
Closed
arminbashizade wants to merge 1 commit into
Closed
Conversation
Netlify deploy previewhttps://deploy-preview-40211--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mountNode prop
Member
|
Closing in favor of #48826. We don't need a new prop. When the container is inside a Shadow Root, we can apply the scrollbar compensation directly to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #39636
I want to know your thoughts about this approach before I add tests and docs.
Currently the suggested way to add a Dialog inside a shadow root is to use
props.container, but I'm thinking a new input is needed on Modal to fix #39636, something likeprops.mountNodeto differentiate betweenModalManagerto handle stylingBecause a Dialog can be inside a container or use
document.body, additionally it can be inside a Shadow DOM or not. These two properties are independent of each other and one cannot be inferred from the other.To use this new prop to add a dialog in a Shadow DOM, follow the MUI docs but instead of setting
containersetmountNode, this will keep usingcontainer(which isdocument.bodyby default) inModalManagerandshadowRootElementto create the Portal: