Fixed issue with skipping first note, progress counter not starting until 2nd note played, and added end of song callback#227
Conversation
-Fixed first note not playing (mudcube#165) -Fixed issue where progress bar would skip silent lead-in
|
Fixed another bug! |
|
Hey @silverhawk184 ! I was trying to use your fixed branch but it is not working. I tried running the gruntfile and it contains outdated paths (polyfill instead of shim). Even when changing the paths and adding missing files, the build doesn't play any sound. It would be nice to have a version that installs like |
|
Hi ,@silverhawk184 I replaced your player.js to the original one , there is still a looping bug when playing the midi file |
|
@silverhawk184 sorry, I downloaded to worry version, but the bug skiping the first chord still exist, eventually,to all guys who met this bug: I copied the module in the author's personal project https://galactic.ink/piano/min/app.js (search the keywords Player),it works well. |
No description provided.