Skip to content

chore: migrate to pnpm@11.27.1 - #847

Merged
kettanaito merged 4 commits into
mainfrom
chore/pnpm-11.27.1
Sep 28, 2026
Merged

kettanaito merged 4 commits into
mainfrom
chore/pnpm-11.27.1

Conversation

@kettanaito

Copy link
Copy Markdown
Member

This pnpm version works with pr.pkg.new linking properly.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 821eb6ca-c6a2-4f4f-9c7a-68a04f476d79

📥 Commits

Reviewing files that changed from the base of the PR and between e77037a and d156eab.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • package.json
  • src/interceptors/WebSocket/web-socket-extension.ts
  • src/interceptors/fetch/node.ts
  • src/interceptors/fetch/web.ts
  • test/modules/fetch/intercept/fetch-relative-url.neutral.test.ts
  • test/third-party/axios.test.ts
  • tsconfig.json
  • vitest.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The package manager version and workflow setup now use pnpm 11.27.1. Test dependencies and configuration are updated, including the test URL and environment. The WebSocket extension accepts handles parameterized with unknown, and fetch interceptor descriptions are revised.

Changes

Toolchain and Test Updates

Layer / File(s) Summary
Align pnpm version across package metadata and workflows
package.json, .github/workflows/ci.yml, .github/workflows/compat.yml, .github/workflows/release-preview.yml, .github/workflows/release.yml
The package manager declaration and workflow setup steps now specify pnpm 11.27.1 instead of 11.5.2.
Update test dependencies and URL configuration
package.json, tsconfig.json, vitest.config.ts, test/modules/fetch/intercept/fetch-relative-url.neutral.test.ts, test/third-party/axios.test.ts
Vitest and Happy DOM dependencies are upgraded. The Node test project uses http://localhost, the relative-URL test uses Happy DOM, and TypeScript import settings permit the explicit .ts extension used by the Vitest configuration. The Axios XHR redirect test uses localhost URLs without port 3000.
Update interceptor signature and descriptions
src/interceptors/WebSocket/web-socket-extension.ts, src/interceptors/fetch/node.ts, src/interceptors/fetch/web.ts
The WebSocket extension apply signature accepts handles parameterized with unknown. Fetch interceptor descriptions are revised, and response destructuring is reformatted without behavior changes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to d156e

This PR aligns pnpm versions, updates test tooling, and broadens the WebSocket extension’s accepted handle type. The reviewed evidence shows no concrete installation or behavior risk, so it appears ready to merge.

Security Architecture Review

Security architecture risk: 🔵 Low · up to d156e

The WebSocket change broadens what callers can pass to the extension, but the inspected runtime behavior is unchanged. The release workflows also adopt a new package-manager version. No new security boundary crossing was identified, though external callers and full release execution were not verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — No new remote-message handling or fetch request path is established by the inspected changes; the effect on callers outside the analyzed repository remains unknown.

Trust Boundaries and Controls

  • observed — The extension method attaches itself to separate client and server handles; the changed method contains no message decoding, authorization check, or transfer between those handles.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the primary change: migrating the project to pnpm 11.27.1.
Description check ✅ Passed The description explains the reason for the pnpm migration and relates directly to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/mswjs/interceptors/@mswjs/interceptors@847

commit: d156eab

@kettanaito
kettanaito merged commit f32b8e3 into main Sep 28, 2026
8 checks passed
@kettanaito
kettanaito deleted the chore/pnpm-11.27.1 branch September 28, 2026 09:30
@kettanaito

Copy link
Copy Markdown
Member Author

Released: v0.45.5 🎉

This has been released in v0.45.5.

Get these changes by running the following command:

npm i @mswjs/interceptors@latest

Predictable release automation by Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant