feat: use build-time ldflags for Version() string#29
Merged
Conversation
Replace hard-coded version with package-level var set via -X linker flag at build time. Defaults to 'dev' for local development. Related to msutara/config-manager-core#86 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the network plugin’s reported version to be injected at build time (via Go -ldflags -X) instead of being hard-coded in the plugin, aligning the plugin’s Version() with how the core binary is built/released.
Changes:
- Introduces a package-level
var version = "dev"intended to be overridden at link time. - Updates
(*NetworkPlugin).Version()to return theversionvariable instead of a fixed string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hard-coded version string with a package-level
var version = "dev"that gets set via-Xlinker flag at build time from the core binary's Makefile and release workflow.Changes
var version = "dev"at package scope;Version()now returns it instead of hard-coded"0.4.3"How It Works
When core builds the
cmbinary, it passes:-X github.com/msutara/cm-plugin-network.version=0.4.5This sets the unexported
versionvar at link time. Without the flag, it defaults to"dev"for local development.Testing
go build ./...passgo test ./... -count=1pass (metadata test checks non-empty, not specific value)golangci-lint runpassRelated to msutara/config-manager-core#86