fix: bump setup-go v5 to v6, correct version and complete endpoints#28
Merged
fix: bump setup-go v5 to v6, correct version and complete endpoints#28
Conversation
- CI: actions/setup-go v5 → v6 (aligns with all other CM repos) - plugin.go: Version() 0.1.0 → 0.4.3 (matches current release tag) - plugin.go: Endpoints() expanded from 4 to 9 routes to match actual route registrations (was missing PUT, POST rollback, GET by name) - plugin_test.go: updated TestNetworkPlugin_Endpoints accordingly Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates plugin metadata and CI configuration so the network plugin advertises the correct version and exposes all registered HTTP routes via Endpoints() for UI auto-discovery.
Changes:
- Bump GitHub Actions
actions/setup-gofrom v5 to v6 in CI. - Update
NetworkPlugin.Version()to0.4.3. - Expand
NetworkPlugin.Endpoints()and adjust tests to cover all 9 routes registered inroutes.go.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Updates CI to use actions/setup-go@v6. |
plugin.go |
Corrects plugin version and enumerates all 9 discoverable endpoints. |
plugin_test.go |
Updates endpoint test expectations to match the expanded endpoint list. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
actions/setup-gov5 → v6 (aligns with all other CM repos)Version()corrected from0.1.0to0.4.3to match current release tagEndpoints()expanded from 4 to 9 routes to match actual route registrations inroutes.go. Previously missing:GET /interfaces/{name},PUT /interfaces/{name},POST /interfaces/{name}/rollback,PUT /dns,POST /dns/rollbackTestNetworkPlugin_Endpointsupdated to validate all 9 endpointsWhy this matters
The
Endpoints()slice is used by the web dashboard and TUI for auto-discovery of available plugin operations. With only 4 of 9 routes listed, write operations (static IP, DNS, rollback) were invisible to auto-generated UI menus.All tests pass locally with
GOWORK=off.