feat(satellite): two-way bearing sync between modal and main map#736
Merged
Conversation
Rotating the satellite modal map now rotates the main map and vice versa. A _syncingBearing guard prevents the set→event→set feedback loop; the main-map rotate listener is detached on modal close. Adds window.__satModalMap test hook and asserts both sync directions. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
🚀 Preview deployed
Commit: |
The static satellite snippet in the waypoint inspector now rotates its tile layer to match the main map's bearing (crosshair/attribution stay upright). A one-time map rotate listener keeps a visible preview aligned live as the dial or the satellite modal's two-way sync changes the bearing. Tiles sit in a new .satellite-snippet-tiles layer; the 3×3 overscan hides corner gaps. Co-authored-by: Cursor <cursoragent@cursor.com>
…itForFunction The test awaited getRegistration() multiple times and only handled active|installing, so a registration in the 'waiting' state (or a transient null worker slot) threw 'Cannot read properties of null' or returned null. Poll inside waitForFunction until a worker slot (active/waiting/installing) exposes a scriptURL, then assert. Verified stable across repeated runs. Co-authored-by: Cursor <cursoragent@cursor.com>
The static snippet rotated opposite to the main map. Apply rotate(+bearing) so it matches the live (leaflet-rotate) modal map's orientation. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rotating the satellite view modal map now rotates the main map and vice versa. A
_syncingBearingguard prevents the set→event→set feedback loop, and the main-map rotate listener is detached on modal close. Addswindow.__satModalMaptest hook and asserts both sync directions.(Orientation-on-open + the rotation dial itself already landed via #733.) Closes #735
Made with Cursor