Incorrect multiplier in a53-pll freq_tbl#431
Open
Auroir wants to merge 1 commit intomsm8916-mainline:wip/msm8916/6.19from
Open
Incorrect multiplier in a53-pll freq_tbl#431Auroir wants to merge 1 commit intomsm8916-mainline:wip/msm8916/6.19from
Auroir wants to merge 1 commit intomsm8916-mainline:wip/msm8916/6.19from
Conversation
1152000000 = 60 * 19200000 (xo-clock) Currently if you add 1152000000 (60x) to your device tree you receive a PLL of 1190400000 (62x). Signed-off-by: Radar J’rooti <Auroir@protonmail.com>
Member
|
Looks like you're right, downstream has 60 as well: static struct pll_freq_tbl apcs_pll_freq[] = {
F_APCS_PLL( 998400000, 52, 0x0, 0x1, 0x0, 0x0, 0x0),
F_APCS_PLL(1094400000, 57, 0x0, 0x1, 0x0, 0x0, 0x0),
F_APCS_PLL(1152000000, 60, 0x0, 0x1, 0x0, 0x0, 0x0), // <----
F_APCS_PLL(1190400000, 62, 0x0, 0x1, 0x0, 0x0, 0x0),
F_APCS_PLL(1209600000, 63, 0x0, 0x1, 0x0, 0x0, 0x0),
F_APCS_PLL(1248000000, 65, 0x0, 0x1, 0x0, 0x0, 0x0),
F_APCS_PLL(1363200000, 71, 0x0, 0x1, 0x0, 0x0, 0x0),
F_APCS_PLL(1401600000, 73, 0x0, 0x1, 0x0, 0x0, 0x0),
PLL_F_END
};Can you send this upstream to the Linux kernel mailing lists? |
Author
|
It looks like your example has 62x as well as 60x. Should this patch instead be making entries for both? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
1152000000 = 62 * 19200000 (xo-clock)
To
1152000000 = 60 * 19200000 (xo-clock)
Currently if you add 1152000000 (60x) to your device tree you receive a PLL of 1190400000 (62x).
Perhaps it was intended for there to be a frequency level for scenarios where a 1.2GHz limit is strictly enforced thereby disallowing 1.21GHz (63x), in which case the problem is labeling it as 1152000000 when it's 1190400000. But I think it's more likely that the intent was a smooth range of frequencies to choose from so I fixed the multiplier.