Fix PR #87 review issues: Python bug fixes and .nf module safety#240
Open
johnoooh wants to merge 3 commits intoneoantigenfrom
Open
Fix PR #87 review issues: Python bug fixes and .nf module safety#240johnoooh wants to merge 3 commits intoneoantigenfrom
johnoooh wants to merge 3 commits intoneoantigenfrom
Conversation
- C1: Guard empty score_list and zero Kd/KdWT in compute_fitness.py - C2: Add amino acid X support, missing-key guards, and variable-length epitope distance in EpitopeDistance.py - C3: BioPython PairwiseAligner fallback, empty alignment guard, and uppercase normalization in align_neoantigens_to_IEDB.py - C4: Initialize PTC_exon before loop and guard None best_pepmatch2 in generate_input.py - C5: Fix "nonsense_nutation" typo in generate_input.py and generateMutFasta.py - I4: Replace destructive `cat >> inputFasta` with safe `cat > combined_input.fa` in netmhcpan4 and netmhcstabpan modules - I5: Close leaked out_WT_fa file handle in generateMutFasta.py Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep only the amino acid X addition and docstring update. Revert set_model() error handling and variable-length epitope_dist() changes per review feedback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Drop amino acid X and docstring change — the model JSON lacks X->* entries, causing KeyError at runtime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature/<module_name>for modules, orfeature/<subworkflow_name>for subworkflows. For modules, if there is a subcommand use:feature/<module_name>/<module_subcommand>.versions.ymlfile.label.nf-core modules --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <module_branch> test <MODULE> --profile dockernf-core modules --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <module_branch> test <MODULE> --profile singularitynf-core modules --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <module_branch> test <MODULE> --profile condanf-core subworkflows --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <subworkflow_branch> test <SUBWORKFLOW> --profile dockernf-core subworkflows --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <subworkflow_branch> test <SUBWORKFLOW> --profile singularitynf-core subworkflows --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <subworkflow_branch> test <SUBWORKFLOW> --profile conda