Skip to content

feat: add Cloud Backup Service agent#363

Open
itlasso wants to merge 2 commits intomsitarzewski:mainfrom
itlasso:feat/cloud-backup-service-agent
Open

feat: add Cloud Backup Service agent#363
itlasso wants to merge 2 commits intomsitarzewski:mainfrom
itlasso:feat/cloud-backup-service-agent

Conversation

@itlasso
Copy link
Copy Markdown
Contributor

@itlasso itlasso commented Mar 28, 2026

What does this PR do?

Adds a new Cloud Backup Service agent to the Engineering Division, specializing in provisioning and operating a managed cloud backup service on AWS S3 with per-client isolation, Terraform infrastructure, macOS and Windows scheduled backup scripts, SNS failure alerting, and secure pre-signed URL file retrieval.

Agent Information (if adding/modifying an agent)

  • Agent Name: Cloud Backup Service Agent
  • Category: Engineering
  • Specialty: AWS S3 per-client bucket provisioning, Terraform modules for backup infrastructure, macOS launchd and Windows Task Scheduler backup automation, gzip compression, SNS email failure alerting, pre-signed URL client file retrieval, and Git repository management for multi-client backup services

Checklist

  • Follows the agent template structure from CONTRIBUTING.md
  • Includes YAML frontmatter with name, description, color
  • Has concrete code/template examples (for new agents)
  • Tested in real scenarios
  • Proofread and formatted correctly

@itlasso
Copy link
Copy Markdown
Contributor Author

itlasso commented Mar 28, 2026

@msitarzewski this agent was built from a real implementation — provisioning per-client AWS S3 buckets with Terraform, deploying scheduled backup scripts for both macOS (launchd) and Windows (Task Scheduler), SNS failure alerting, and pre-signed URL file retrieval. Happy to make any adjustments if needed!

@mhc222
Copy link
Copy Markdown

mhc222 commented Mar 30, 2026

Code review

Found 1 issue:

  1. Invalid HCL syntax in the Terraform output block — HCL does not support semicolons as attribute separators. The sensitive = true attribute on the same line as value will cause terraform validate to fail with a parse error. Each attribute must be on its own line:
output "iam_secret_key" {
  value     = module.iam.iam_secret_key
  sensitive = true
}

output "bucket_name" { value = module.s3_bucket.bucket_name }
output "iam_access_key" { value = module.iam.iam_access_key }
output "iam_secret_key" { value = module.iam.iam_secret_key; sensitive = true }
output "sns_topic_arn" { value = module.sns_alerts.sns_topic_arn }
```

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@itlasso
Copy link
Copy Markdown
Contributor Author

itlasso commented Mar 30, 2026

@mhc222 — fixed the HCL output block syntax. Each attribute is now on its own line and the semicolon separator has been removed.

Added correct emoji prefixes and "Your" phrasing to all section headers. Added missing Learning & Memory and Advanced Capabilities sections. Replaced When to Bring In Other Agents with Advanced Capabilities.
@itlasso
Copy link
Copy Markdown
Contributor Author

itlasso commented Mar 31, 2026

@msitarzewski @mhc222 fixed all section headers with correct emoji prefixes and "Your" phrasing. Added missing ## 🔄 Learning & Memory and ## 🚀 Advanced Capabilities sections. Ready for re-review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants