Skip to content

fix(pdf-quality): bump CLEANUP_TIMEOUT default to 1500s #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrviduus merged 1 commit into from
May 22, 2026
Merged

fix(pdf-quality): bump CLEANUP_TIMEOUT default to 1500s #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ ADMIN_ALERT_EMAIL=
# PDF content cleanup (quality-poll.sh Phase 3 — feat-0007).
# When true, chapters scoring below the threshold get an LLM cleanup pass
# via Claude CLI. Off by default — leaves the poller at structure-only.
# CLEANUP_TIMEOUT: per-chapter Claude budget; large chapters need 10-15 min.
# CLEANUP_TIMEOUT: per-chapter Claude budget; 20k-word chapters take ~15-20 min.
CONTENT_CLEANUP_ENABLED=false
CONTENT_QUALITY_THRESHOLD=60
CLEANUP_TIMEOUT=900
CLEANUP_TIMEOUT=1500
8 changes: 5 additions & 3 deletions infra/scripts/quality-poll.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ API_BASE="http://localhost:8080"
# get an LLM cleanup pass; output is verified by pdf-cleanup-gate.py.
CONTENT_CLEANUP_ENABLED="${CONTENT_CLEANUP_ENABLED:-false}"
CONTENT_QUALITY_THRESHOLD="${CONTENT_QUALITY_THRESHOLD:-60}"
# Per-chapter Claude timeout. Large chapters (15-20k words) need well over the
# old 300s — rewriting that much HTML takes 10-15 min. Env-tunable.
CLEANUP_TIMEOUT="${CLEANUP_TIMEOUT:-900}"
# Per-chapter Claude timeout. 16k-word chapters take ~10 min; 20k+ chapters
# (the longest tech books have) need ~15-20 min — 900s was tight, dropped one
# in prod testing. Env-tunable for the rare outliers; 1500s default covers
# the realistic upper bound.
CLEANUP_TIMEOUT="${CLEANUP_TIMEOUT:-1500}"
DATASET_DIR="$REPO_DIR/data/pdf-cleanup-dataset"
GATE_SCRIPT="$REPO_DIR/infra/scripts/pdf-cleanup-gate.py"

Expand Down
Loading